From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] fdt chosen node handling
Date: Wed, 19 Dec 2007 14:02:15 +0100 [thread overview]
Message-ID: <200712191402.16155.sr@denx.de> (raw)
In-Reply-To: <47690D64.2030704@ge.com>
Hi Jerry,
On Wednesday 19 December 2007, Jerry Van Baren wrote:
> Disclaimer: I am not a OF expert, I have not read the OF documentation
> cover to cover and do not understand many implications of what I've
> read, much less what I have _not_ read.
>
> 1) I believe the /chosen node should be auto-created.
Ufff. :)
> 2) As you point out, if the /chosen node already exists the current code
> bails out and doesn't change anything. This was done as a very badly
> misguided attempt to make libfdt things work like bd_t things. The
> granularity should be on the individual properties, not on /chosen. I
> consider this a bug and have it on my "todo" list to fix (actually, I
> had created a patch, but I need to rebase and publish it).
>
> <http://www.denx.de/wiki/view/UBoot/UBootFdtInfo#Outstanding_Patches>
>
> "Unpublished patch of JerryVanBaren, implementing a suggestion by Scott
> Wood to make the /chosen handling finer grained: if the /chosen node
> exists, currently u-boot-fdt bails out. A better methodology is to not
> overwrite pre-existing properties on a per-property basis, so if /chosen
> exists but a necessary /chosen/property doesn't, it gets created. Good
> idea, but not published and poorly tested at the moment."
OK, thanks for these infos.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2007-12-19 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 7:59 [U-Boot-Users] fdt chosen node handling Stefan Roese
2007-12-19 12:24 ` Jerry Van Baren
2007-12-19 13:02 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712191402.16155.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.