From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH v2 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE Date: Thu, 20 Dec 2007 15:04:54 -0800 Message-ID: <200712201504.54836.david-b@pacbell.net> References: <20071220202714.GA18471@localhost.localdomain> <20071220203322.GC19553@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <20071220203322.GC19553-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thursday 20 December 2007, Anton Vorontsov wrote: > In case of QE we can use brg-frequency (which is qeclk/2). > Thus no need to divide sysclk in the spi_mpc83xx. > = > This patch also adds code to use get_brgfreq() on QE chips. > = > Signed-off-by: Anton Vorontsov > --- > =A0arch/powerpc/sysdev/fsl_soc.c | =A0 37 ++++++++++++++++++++++++-------= ------ > =A0drivers/spi/spi_mpc83xx.c =A0 =A0 | =A0 =A06 +----- > =A02 files changed, 25 insertions(+), 18 deletions(-) For the SPI parts: Acked-by: David Brownell Though it all looks a bit confusing to me, and I wonder if the OF docs would make it less so. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp123.sbc.mail.sp1.yahoo.com (smtp123.sbc.mail.sp1.yahoo.com [69.147.64.96]) by ozlabs.org (Postfix) with SMTP id C35A9DDDEA for ; Fri, 21 Dec 2007 10:04:57 +1100 (EST) From: David Brownell To: spi-devel-general@lists.sourceforge.net Subject: Re: [spi-devel-general] [PATCH v2 3/4] [POWERPC][SPI] use brg-frequency for SPI in QE Date: Thu, 20 Dec 2007 15:04:54 -0800 References: <20071220202714.GA18471@localhost.localdomain> <20071220203322.GC19553@localhost.localdomain> In-Reply-To: <20071220203322.GC19553@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200712201504.54836.david-b@pacbell.net> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 20 December 2007, Anton Vorontsov wrote: > In case of QE we can use brg-frequency (which is qeclk/2). > Thus no need to divide sysclk in the spi_mpc83xx. > > This patch also adds code to use get_brgfreq() on QE chips. > > Signed-off-by: Anton Vorontsov > --- >  arch/powerpc/sysdev/fsl_soc.c |   37 ++++++++++++++++++++++++------------- >  drivers/spi/spi_mpc83xx.c     |    6 +----- >  2 files changed, 25 insertions(+), 18 deletions(-) For the SPI parts: Acked-by: David Brownell Though it all looks a bit confusing to me, and I wonder if the OF docs would make it less so.