All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@shadowen.org>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frans Pop <elendil@planet.nl>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	trivial@kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
	Joel Schopp <jschopp@austin.ibm.com>
Subject: Re: Trailing periods in kernel messages
Date: Thu, 20 Dec 2007 17:22:50 -0500	[thread overview]
Message-ID: <20071220222250.GJ27081@thunk.org> (raw)
In-Reply-To: <20071220215411.183d03c0@the-village.bc.nu>

On Thu, Dec 20, 2007 at 09:54:11PM +0000, Alan Cox wrote:
> > Kernel messages do not have to be terminated with a period.
> 
> This piece of the document is wrong. It should also be changed. I've no
> idea how such a ludicrous statement ever got into the Coding Style but I
> have never seen it discussed and an archive search suggests it just
> sneaked in without any kind of approval and discussion the list.
> 
> Kernel messages are in English. Let us keep it that way. Missing
> punctuation is equated by many parts of the English speaking world with
> poor quality, sloppy products and low levels of education. These are not
> things with which we wish to be associated IMHO.

Um, what?  Kernel messages are *not* in English.

Take a look at a machine after it is freshly booted.  The following
messages are *not* English:

[    0.000000] BIOS-provided physical RAM map:
[    0.000000]  BIOS-e820: 0000000000000000 - 0000000000099800 (usable)
[    0.000000]  BIOS-e820: 0000000000099800 - 00000000000a0000 (reserved)
[    0.000000]  BIOS-e820: 00000000000d6000 - 00000000000d8000 (reserved)
[    0.000000]  BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved)
[    0.000000]  BIOS-e820: 0000000000100000 - 00000000bf6b0000 (usable)
[    0.000000]  BIOS-e820: 00000000bf6b0000 - 00000000bf6cc000 (ACPI data)
[    0.000000]  BIOS-e820: 00000000bf6cc000 - 00000000bf700000 (ACPI NVS)
[    0.000000]  BIOS-e820: 00000000bf700000 - 00000000c0000000 (reserved)
[    0.000000]  BIOS-e820: 00000000f0000000 - 00000000f4000000 (reserved)
[    0.000000]  BIOS-e820: 00000000fec00000 - 00000000fec10000 (reserved)

Do you really want to turn that into complete English sentences?

Or how about these?

[   15.069322] IP route cache hash table entries: 32768 (order: 5, 131072 bytes)
[   15.069830] TCP established hash table entries: 131072 (order: 8, 1048576 bytes)
[   15.070448] TCP bind hash table entries: 65536 (order: 9, 2359296 bytes)
[   15.077264] TCP: Hash tables configured (established 131072 bind 65536)
[   15.077278] TCP reno registered
[   15.086122] checking if image is initramfs... it is
[   15.846658] Freeing initrd memory: 7114k freed

Again, not sentences, and I don't think making every single printk a
gramatically valid sentence is a good thing.  Or even necessary.  And
in some cases, it would make the kernel messages harder to parse by an
automated log parser.

					- Ted

  parent reply	other threads:[~2007-12-20 22:23 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  7:35 [PATCH 6/6] tick: add a missing dot in prink Li Zefan
2007-11-29  8:58 ` Frans Pop
2007-11-29  9:29   ` Li Zefan
2007-11-29 10:20     ` Trailing periods in kernel messages (was: [PATCH 6/6] tick: add a missing dot in prink) Frans Pop
2007-11-29 11:20       ` Andrew Morton
2007-11-30  1:12         ` Trailing periods in kernel messages Li Zefan
2007-11-30  1:30           ` Joe Perches
2007-11-30  1:54             ` Li Zefan
2007-11-30  2:35               ` Joe Perches
2007-12-20 16:29                 ` Andy Whitcroft
2007-12-20 21:07                   ` Alan Cox
2007-12-20 21:43                     ` Joe Perches
2007-12-20 21:54                       ` Alan Cox
2007-12-20 22:19                         ` Andrew Morton
2007-12-20 22:34                           ` Randy Dunlap
2007-12-20 23:40                           ` Alan Cox
2007-12-20 22:22                         ` Theodore Tso [this message]
2007-12-20 23:38                           ` Alan Cox
2007-12-21 15:54                       ` Lennart Sorensen
2007-12-20 21:51                     ` David Miller
2007-12-20 22:07                       ` Joe Perches
2007-12-20 22:08                         ` Alan Cox
2007-12-20 23:14                           ` J.A. Magallón
2007-12-21  0:04                           ` Joe Perches
2007-12-21  0:40                             ` Alan Cox
2007-12-21  9:56                           ` Herbert Xu
2007-12-21 10:10                             ` Jan Engelhardt
2007-12-21 10:12                               ` David Miller
2007-12-21 13:43                                 ` David Newall
2007-12-21 14:01                                   ` David Miller
2007-12-21 15:37                                     ` David Newall
2007-12-21 11:41                               ` Herbert Xu
2007-12-21 11:55                                 ` Jan Engelhardt
2007-12-21 16:01                                   ` Lennart Sorensen
2007-12-22 14:04                                     ` Benny Amorsen
2007-12-22 20:20                                       ` Radoslaw Szkodzinski
2007-12-21 12:06                               ` David Schwartz
2007-12-21 15:18                               ` Stefan Richter
2007-12-20 22:09                       ` Roland Dreier
2007-12-21  1:43                     ` Frans Pop
2007-12-21  2:15                       ` Andrew Morton
2007-12-21  3:12                         ` David Miller
2007-12-21 10:15                         ` Jan Engelhardt
2007-12-21 10:21                       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071220222250.GJ27081@thunk.org \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=apw@shadowen.org \
    --cc=elendil@planet.nl \
    --cc=joe@perches.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.