From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH] ASoC drivers for the Freescale MPC8610 SoC Date: Thu, 20 Dec 2007 16:39:44 -0600 Message-ID: <20071220223943.GA24138@lixom.net> References: <11981089894052-git-send-email-timur@freescale.com> <20071220040633.GA6732@lixom.net> <476A7B23.2040905@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <476A7B23.2040905@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Timur Tabi Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, Dec 20, 2007 at 08:24:35AM -0600, Timur Tabi wrote: > Olof Johansson wrote: > > >> +static struct of_device_id mpc8610_ids[] = { > >> + { .type = "soc", }, > >> + {} > > > > Please scan based on compatible instead of device_type. > > I was just following the example from another board file. However, the 'soc' > node in the device tree does not have a compatible property, so I don't how to > change this. Then add an appropriate compatible entry to it, please. > > Do you ever anticipate having other dma users on the system, such as > > memcpy offload? You'll probably need allocation support for channels > > when that day comes (I ended up writing a simple library for dma channel > > management for that very reason on my platform). > > Yes, I plan on updating this driver to work with the standard Freescale "Elo" > device driver, but that will have to wait until that code is in the kernel and > stabilized. The SSI is limited in which DMA channels it can use, anyway. Ok. -Olof