From: Alex Riesen <raa.lkml@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: [PATCH] Fix thinko in checking for commit message emptiness
Date: Fri, 21 Dec 2007 00:48:49 +0100 [thread overview]
Message-ID: <20071220234849.GF3052@steel.home> (raw)
In-Reply-To: <20071220233539.GC3052@steel.home>
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Sorry. It must be late. It it must have been late yesterday
and still is today.
builtin-commit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 1356d20..eae7661 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -436,7 +436,7 @@ static int message_is_empty(struct strbuf *sb, int start)
int eol, i;
if (verbatim_message && sb->len)
- return 1;
+ return 0;
/* See if the template is just a prefix of the message. */
strbuf_init(&tmpl, 0);
--
1.5.4.rc1.33.gbd32b
next prev parent reply other threads:[~2007-12-20 23:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 21:18 [PATCH] git-commit: add --verbatim to allow unstripped commit messages Alex Riesen
2007-12-20 21:40 ` Linus Torvalds
2007-12-20 23:33 ` Alex Riesen
2007-12-20 23:35 ` Alex Riesen
2007-12-20 23:37 ` [PATCH] Only filter "#" comments from commits if the editor is used Alex Riesen
2007-12-20 23:39 ` Junio C Hamano
2007-12-20 23:43 ` Alex Riesen
2007-12-20 23:43 ` Junio C Hamano
2007-12-20 23:48 ` Alex Riesen [this message]
2007-12-20 23:55 ` [PATCH] git-commit: add --verbatim to allow unstripped commit messages Linus Torvalds
2007-12-21 0:14 ` Björn Steinbrink
2007-12-21 0:49 ` Linus Torvalds
2007-12-20 23:50 ` Junio C Hamano
2007-12-21 0:03 ` Linus Torvalds
2007-12-21 17:35 ` [PATCH] Allow selection of different cleanup modes for " Alex Riesen
2007-12-21 21:43 ` Junio C Hamano
2007-12-21 23:08 ` Alex Riesen
2007-12-22 7:59 ` Junio C Hamano
2007-12-22 18:46 ` Alex Riesen
2007-12-22 19:18 ` Linus Torvalds
2007-12-22 19:41 ` Junio C Hamano
2007-12-23 3:01 ` Junio C Hamano
2007-12-23 3:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220234849.GF3052@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.