From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: devel@openvz.org, netdev@vger.kernel.org, kaber@trash.net,
kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket
Date: Fri, 21 Dec 2007 01:33:21 -0800 (PST) [thread overview]
Message-ID: <20071221.013321.164620125.davem@davemloft.net> (raw)
In-Reply-To: <20071221090043.GA25484@iris.sw.ru>
From: "Denis V. Lunev" <den@openvz.org>
Date: Fri, 21 Dec 2007 12:00:43 +0300
> nl_fib_input re-reuses incoming skb to send the reply. This means that this
> packet will be freed twice, namely in:
> - netlink_unicast_kernel
> - on receive path
> Use clone to send as a cure, the caller is responsible for kfree_skb on error.
>
> Thanks to Alexey Dobryan, who originally found the problem.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
What introduced this bug? This code didn't have this
problem previously.
next prev parent reply other threads:[~2007-12-21 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 9:00 [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket Denis V. Lunev
2007-12-21 9:33 ` David Miller [this message]
2007-12-21 9:39 ` Denis V. Lunev
2007-12-21 9:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221.013321.164620125.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.