From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761712AbXLUOW3 (ORCPT ); Fri, 21 Dec 2007 09:22:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752754AbXLUOWV (ORCPT ); Fri, 21 Dec 2007 09:22:21 -0500 Received: from brick.kernel.dk ([87.55.233.238]:25294 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbXLUOWU (ORCPT ); Fri, 21 Dec 2007 09:22:20 -0500 Date: Fri, 21 Dec 2007 15:22:22 +0100 From: Jens Axboe To: Adrian McMenamin Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Paul Mundt Subject: Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device Message-ID: <20071221142222.GG11583@kernel.dk> References: <8b67d60712201559h5dbb2a17q8f16223b26b88006@mail.gmail.com> <8b67d60712201607k66d67fa2la8b21fc698fdb3ab@mail.gmail.com> <20071221121441.GB11583@kernel.dk> <8b67d60712210611j6169e262vd761b1d1aca75eb4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b67d60712210611j6169e262vd761b1d1aca75eb4@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 21 2007, Adrian McMenamin wrote: > On 21/12/2007, Jens Axboe wrote: > > > > Your design is also heavily geared towards there just being a single > > CDROM, I'm assuming this wont be a problem given your hw (it sets a bad > > example for others to follow though, lots of violations against normal > > programming practice for multiple devices and smp). > > > Yes, because is there only one device and there will only ever be one > device (unless you know of somebody doing Dreamcast hardware > development). > > I understand the point you are making but adding in additional code > would only diminish resource availability or slow performance on a > small machine without actually delivering any better outcomes for > kernel users.. > > Is it reaslly necessary? No it's not necessary, it was just a general reflection on how it could have been done more in style with "regular" drivers. -- Jens Axboe