From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] Fix xend xenstore handling Date: Fri, 21 Dec 2007 15:31:35 +0000 Message-ID: <20071221153135.GC5345@redhat.com> References: <20071221145726.GA16971@totally.trollied.org.uk> <20071221150803.GA5345@redhat.com> <20071221152713.GB16971@totally.trollied.org.uk> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20071221152713.GB16971@totally.trollied.org.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Dec 21, 2007 at 03:27:13PM +0000, John Levon wrote: > On Fri, Dec 21, 2007 at 03:08:03PM +0000, Daniel P. Berrange wrote: > > > > This is the cause of the "reboot loop" xend failures I reported earlier. > > > Note that I've only tested this patch against 3.1, however the code, > > > and the fix, is the same in unstable. I realise it's late in the cycle > > > but this bug is bad enough to need fixing IMHO. > > > > I think the entire code segment from the point at which xstransact() is > > created needs to be in a try...finally block to be safe against the > > code throwing exceptions, otherwise you could very ocassionally get the > > final xs.abort() being missed in error conditions. > > OK, how about this one? (I'm starting testing it now) Yep, that looks good to me. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|