From: Ingo Oeser <netdev@axxeo.de>
To: David Miller <davem@davemloft.net>
Cc: xemul@openvz.org, netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function
Date: Fri, 21 Dec 2007 18:53:51 +0100 [thread overview]
Message-ID: <200712211853.52230.netdev@axxeo.de> (raw)
In-Reply-To: <20071220.160840.140150524.davem@davemloft.net>
Hi David,
David Miller schrieb:
> "inet_timewait_sock" begins with a "struct sock_common"
> which is where the atomic_t is, and:
>
> #define tw_refcnt __tw_common.skc_refcnt
>
> So you would have to change struct sock_common over to kref, and thus
> the entire networking, in order to make such a change.
Ok, that sounds too much. Many thanks for following up and taking the time
to explain it.
> But you would have seen this instantly if you had spent 5 seconds
> looking at how these datastructures are defined. Instead you choose
> to make me do it and explain it to you instead.
Sorry, just matched the wrong pattern here :-)
Best Regards
Ingo Oeser
next prev parent reply other threads:[~2007-12-21 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 10:56 [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function Pavel Emelyanov
2007-12-20 18:32 ` Ingo Oeser
2007-12-21 0:08 ` David Miller
2007-12-21 17:53 ` Ingo Oeser [this message]
2007-12-20 23:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712211853.52230.netdev@axxeo.de \
--to=netdev@axxeo.de \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.