From: Jens Axboe <jens.axboe@oracle.com>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Adrian McMenamin <lkmladrian@gmail.com>,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device
Date: Fri, 21 Dec 2007 20:35:06 +0100 [thread overview]
Message-ID: <20071221193505.GA26896@kernel.dk> (raw)
In-Reply-To: <1198264359.7235.1.camel@localhost.localdomain>
On Fri, Dec 21 2007, Adrian McMenamin wrote:
>
> On Fri, 2007-12-21 at 13:14 +0100, Jens Axboe wrote:
>
> >
> > What is pages doing in gdrom_request()?
> >
>
> As the device doesn't do scatter-gather I've set
> blk_queue_max_segment_size to 1 and am not bothering with pages - is
> that wrong?
I mean this:
unsigned long pages;
pages = rq->backing_dev_info.ra_pages;
and you never use 'pages'.
--
Jens Axboe
next prev parent reply other threads:[~2007-12-21 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 23:59 [PATCH - SH/Dreamcast] Add support for GD-Rom device Adrian McMenamin
2007-12-21 0:07 ` Adrian McMenamin
2007-12-21 12:14 ` Jens Axboe
2007-12-21 12:26 ` Jens Axboe
2007-12-21 14:11 ` Adrian McMenamin
2007-12-21 14:22 ` Jens Axboe
2007-12-21 14:43 ` Adrian McMenamin
2007-12-21 15:01 ` Jens Axboe
2007-12-21 19:12 ` Adrian McMenamin
2007-12-21 19:35 ` Jens Axboe [this message]
2007-12-21 19:53 ` Adrian McMenamin
2007-12-22 10:44 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221193505.GA26896@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=adrian@newgolddream.dyndns.info \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkmladrian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.