Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection

[Willy Tarreau <w@1wt.eu>]

Hi Jan,

On Fri, Dec 21, 2007 at 10:10:24PM +0100, Jan Engelhardt wrote:
> 
> On Dec 21 2007 15:31, Eric Paris wrote:
> >On Thu, 2007-12-20 at 00:29 +0100, Jan Engelhardt wrote:
> >> On Dec 19 2007 16:59, Eric Paris wrote:
> >> >
> >> >+config SECURITY_DEFAULT_MMAP_MIN_ADDR
> >> >+        int "Low address space to protect from user allocation"
> >> 
> >> Hm, should not this be 'hex'?
> >
> >I guess it could be, but the input for /proc/sys/vm/mmap_min_addr is
> >base 10 as well
> 
> sysfs is autobase, i.e. echo "0xb000" >/sys/foo will Do The Right Thing.

yes but if you cat  /proc/sys/vm/mmap_min_addr, it returns in base 10.
While most of us have no problem doing an instant conversion, many
people will find it painful to convert the output of cat before copying
it into their .config.

I'm generally for hex, but here I'd prefer to stay with the in-place
format which is already decimal. And as you said, people can still
write the hex value into /proc/sys if they want to.

Regards,
Willy