From: Pierre Habouzit <madcoder@debian.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-tag: fix -l switch handling regression.
Date: Fri, 21 Dec 2007 22:18:33 +0100 [thread overview]
Message-ID: <20071221211833.GA10318@artemis.madism.org> (raw)
In-Reply-To: <7vd4t0atzo.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Fri, Dec 21, 2007 at 04:32:43PM +0000, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
>
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> > ---
> >
> > It seems that you didnt took that patch either, that IMHO gives a better
> > semantics to git tag -l than yours, while keeping backward
> > compatibility.
>
> I thought this depended on some other changes. As is, doesn't
> it break the t7004 test?
Well there are tests that test:
git tag -n xxx -l ...
or
git tag -n "" -l ...
but I think we agreed those test nothing legitimate, and that the
tests have to be removed. SO yes it hides another patch to cleanse t7004
from the broken tests.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-12-21 21:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 0:32 1.5.4-rc2 plans Junio C Hamano
2007-12-21 7:26 ` Johannes Sixt
2007-12-21 9:09 ` Mike Frysinger
2007-12-22 15:04 ` Johannes Schindelin
2007-12-22 17:54 ` Mike Frysinger
2007-12-21 8:57 ` Steven Grimm
2007-12-21 10:47 ` Pierre Habouzit
2007-12-21 10:50 ` [PATCH] git-tag: fix -l switch handling regression Pierre Habouzit
2007-12-21 16:32 ` Junio C Hamano
2007-12-21 21:18 ` Pierre Habouzit [this message]
2007-12-22 8:01 ` Junio C Hamano
2007-12-21 11:06 ` 1.5.4-rc2 plans Junio C Hamano
2007-12-21 11:13 ` Pierre Habouzit
2007-12-21 11:19 ` [PATCH] parse-options: Add a gitcli(5) man page Pierre Habouzit
2007-12-22 15:05 ` 1.5.4-rc2 plans Johannes Schindelin
2007-12-22 17:03 ` Pierre Habouzit
2007-12-22 17:16 ` Junio C Hamano
2007-12-22 17:38 ` Pierre Habouzit
2007-12-22 17:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221211833.GA10318@artemis.madism.org \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.