From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] (resent) NUMA node migration Date: Fri, 21 Dec 2007 22:45:55 +0000 Message-ID: <20071221224554.GG27601@redhat.com> References: <476C40BE.1030907@amd.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <476C40BE.1030907@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andre Przywara Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Dec 21, 2007 at 11:39:58PM +0100, Andre Przywara wrote: > forgot my signed-off, thus resent... > > the following patch adds NUMA node migration based on live migration to > xend. By adding another parameter to "xm migrate" the target NUMA node > number gets propagated to the target host (can be both localhost or a > remote host). The restore function then sets the VCPU affinity > accordingly. Only changes Python code in xend. I hope that the patch > doesn't break XenAPI compatibility (adding a parameter seems fine?). > > # xm migrate --live --node= localhost > is the number as shown with 'xm info' under node_to_cpu > > I am aware that using live migration isn't the best approach (takes > twice the memory and quite some time), but it's less intrusive and works > fine (given localhost migration stability...) > > Feedback appreciated, especially since I speak Python since Monday... Rather than using '-1' to indiciate no pinning, it is more common python practice to use None, which indicates no value. Other than that it looks reasonable Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|