From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J63JV-00071Q-Vz for mharc-grub-devel@gnu.org; Sat, 22 Dec 2007 07:18:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J63JT-0006xV-4V for grub-devel@gnu.org; Sat, 22 Dec 2007 07:18:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J63JQ-0006qK-1B for grub-devel@gnu.org; Sat, 22 Dec 2007 07:18:42 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J63JP-0006qF-Tp for grub-devel@gnu.org; Sat, 22 Dec 2007 07:18:39 -0500 Received: from [69.60.117.155] (helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J63JQ-0001LB-30 for grub-devel@gnu.org; Sat, 22 Dec 2007 07:18:40 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1J63JM-0000jZ-OJ for grub-devel@gnu.org; Sat, 22 Dec 2007 13:18:37 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1J63JD-0007CS-Ap for grub-devel@gnu.org; Sat, 22 Dec 2007 13:18:27 +0100 Date: Sat, 22 Dec 2007 13:18:27 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071222121827.GA27503@thorin> References: <20071216153046.GA11912@thorin> <87prx5nwd5.fsf@xs4all.nl> <1197915991.2541.3.camel@dv> <20071220173607.GA20508@thorin> <8763ysyoyf.fsf@xs4all.nl> <20071221180405.GA14997@thorin> <20071221205431.GA31264@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: embedding filesystems in core image (Re: moving ata initialisation to a command) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2007 12:18:43 -0000 Here's a new patch, with some cleanup. The main difference is that memdisk.c doesn't include any arch-specific code. I've spotted a memory management problem. The memdisk image, at the location that it's usually uncompressed, tends to collide with the payload loading region (grub_os_area_{addr,size}). I'm not sure what would be a good solution to this. Perhaps we could copy it to dynamic memory in grub_memdisk_init() ? However, if user plays with payload images without booting them, and then loads memdisk.mod manually, things could break. Although, embedding a memdisk image without embedding memdisk.mod is kind of silly; perhaps grub-mkimage shouldn't allow it. What do you think? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)