All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Wyckoff <pw@osc.edu>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
	Jens Axboe <jens.axboe@oracle.com>,
	Mike Christie <michaelc@cs.wisc.edu>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: bidi, varlen, bsg success report
Date: Sat, 22 Dec 2007 15:15:58 -0500	[thread overview]
Message-ID: <20071222201558.GA25063@osc.edu> (raw)

I spent the last couple of days rebasing my working set of kernel
patches from 2.6.22-rc5 to 2.6.24-rc6.  I want to use the BSG
interface from userspace to submit variable-length bidirectional
SCSI commands to targets via iSCSI TCP.

Many thanks to all the work with scsi data accessors and iscsi that
makes this much easier, and to Boaz for continuing to maintain
patches.  Here's what I needed to do to make it work.

Start with linus-2.6.24-rc6.
Merge scsi-misc.
Apply the following outstanding patches from Boaz:

bidi
    scsi: scsi_data_buffer
    http://marc.info/?l=linux-scsi&m=119754650614813&w=2

    scsi: bidi support
    http://marc.info/?l=linux-scsi&m=119754667915055&w=2

varlen
    [PATCH 1/3] Let scsi_cmnd->cmnd use request->cmd buffer
    http://marc.info/?l=linux-scsi&m=119798523823750&w=2

    [PATCH 2/2] block layer varlen-cdb
    http://marc.info/?l=linux-scsi&m=119798548624218&w=2

    [PATCH 3/3] scsi: varlen extended and vendor-specific cdbs
    http://marc.info/?l=linux-scsi&m=119798563924476&w=2

Then a few more, two modified from earlier Boaz patches, and three
new ones by me, mainly to make bsg work.  They follow.

1. iscsi: extended cdb support
Adapted from Boaz
http://marc.info/?l=linux-scsi&m=119394074127857&w=2

2. iscsi: bidi support
Adapted from two old Boaz patches that can be found in this git:
http://www.bhalevy.com/git/gitweb.cgi?p=open-osd/.git;a=commitdiff;h=b5a97649eadb9434acbc4170a8aebd962af6d960
http://www.bhalevy.com/git/gitweb.cgi?p=open-osd/.git;a=commitdiff;h=cf3d4684a22bde6787f2eccee66d7b0ee9c9182c

3. bsg: accept varlen commands

4. bsg: bidi fix

5. iscsi tcp: bidi capable

Suggestions:  Boaz is probably the best qualified to shepherd his
outstanding five patches plus the two others I mention above (#1,
#2).  The first bsg patch (#3) won't apply without the varlen
patches.  The last two (#4, #5) are harmless and can go in now, but
won't matter until the bidi patches are in.  Comments on these
welcome.

Hope this is helpful.  I'm definitely looking forward to seeing
all this merged into mainline eventually.

		-- Pete

             reply	other threads:[~2007-12-22 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 20:15 Pete Wyckoff [this message]
2007-06-21 18:04 ` [PATCH 3/5] bsg: accept varlen commands Pete Wyckoff
2007-11-01 16:10 ` [PATCH 1/5] iscsi: extended cdb support Pete Wyckoff
2007-12-22 20:10 ` [PATCH 2/5] iscsi bidi support Pete Wyckoff
2007-12-22 20:10 ` [PATCH 4/5] bsg: bidi fix Pete Wyckoff
2007-12-22 20:10 ` [PATCH 5/5] iscsi tcp bidi capable Pete Wyckoff
2007-12-22 20:35 ` [PATCH 1/5] iscsi: extended cdb support Pete Wyckoff
2007-12-22 20:35 ` [PATCH 3/5] bsg: accept varlen commands Pete Wyckoff
2007-12-23  9:50 ` bidi, varlen, bsg success report Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071222201558.GA25063@osc.edu \
    --to=pw@osc.edu \
    --cc=James.Bottomley@SteelEye.com \
    --cc=bharrosh@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.