From: Pete Zaitcev <zaitcev@redhat.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@linux-foundation.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, linux@bohmer.net,
jonathan@jonmasters.org, matthias.kaehlcke@gmail.com,
kjwinchester@gmail.com, zaitcev@redhat.com
Subject: Re: [PATCH 4/4] usb: libusual: locking cleanup
Date: Sat, 22 Dec 2007 23:37:33 -0800 [thread overview]
Message-ID: <20071222233733.3a4e94b0.zaitcev@redhat.com> (raw)
In-Reply-To: <1198342910.2742.14.camel@imap.mvista.com>
On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <dwalker@mvista.com> wrote:
> Then in usu_probe_thread() your basically stopping it at the start of
> the function with a down(), and the up() is just ancillary .. So you
> could easily move the up() further down in the function and still have
> the same level of exclusion..
The unfortunate complication here is request_module. I didn't want to
keep a semaphore locked across it, in case child waits for something.
I wonder if there may be some deadlock that we cannot foresee.
But I guess it won't hurt to try.
I tested the patch and it seems to work ok.
-- Pete
next prev parent reply other threads:[~2007-12-23 7:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 8:00 [PATCH 1/4] usb microtek: remove unused semaphore Daniel Walker
2007-12-21 8:00 ` Daniel Walker
2007-12-21 8:00 ` [PATCH 2/4] prism54: remove questionable down_interruptible usage Daniel Walker
2007-12-21 8:00 ` [PATCH 3/4] docs: convert kref semaphore to mutex Daniel Walker
2007-12-21 21:33 ` Corey Minyard
2007-12-21 8:00 ` [PATCH 4/4] usb: libusual: locking cleanup Daniel Walker
2007-12-22 4:22 ` Andrew Morton
2007-12-22 6:24 ` Pete Zaitcev
2007-12-22 6:31 ` Andrew Morton
2007-12-22 17:01 ` Daniel Walker
2007-12-23 7:37 ` Pete Zaitcev [this message]
2007-12-23 16:46 ` Daniel Walker
2007-12-24 14:12 ` Pete Zaitcev
2007-12-24 16:04 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071222233733.3a4e94b0.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=jonathan@jonmasters.org \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@bohmer.net \
--cc=matthias.kaehlcke@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.