From: Al Viro <viro@ftp.linux.org.uk>
To: clameter@sgi.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: tlb_finish_mmu() bogisity
Date: Sun, 23 Dec 2007 09:32:41 +0000 [thread overview]
Message-ID: <20071223093241.GR8181@ftp.linux.org.uk> (raw)
tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0;
makes no sense whatsoever. How the hell can you ever get the address of
__get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have
higher precedence than prefix ones, so that's
&(((__get_cpu_var(quicklist))[0]).nr_pages)
What did you intend here? s/&//, perhaps?
next reply other threads:[~2007-12-23 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 9:32 Al Viro [this message]
2007-12-23 21:15 ` tlb_finish_mmu() bogisity Linus Torvalds
2007-12-24 19:25 ` Christoph Lameter
2007-12-26 20:43 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071223093241.GR8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.