From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J6tFz-0001ov-PA for mharc-grub-devel@gnu.org; Mon, 24 Dec 2007 14:46:35 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J6tFy-0001oe-FX for grub-devel@gnu.org; Mon, 24 Dec 2007 14:46:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J6tFx-0001oE-4y for grub-devel@gnu.org; Mon, 24 Dec 2007 14:46:33 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J6tFw-0001o5-Uw for grub-devel@gnu.org; Mon, 24 Dec 2007 14:46:33 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J6tFw-0002FZ-Na for grub-devel@gnu.org; Mon, 24 Dec 2007 14:46:32 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 132CE3EB23 for ; Mon, 24 Dec 2007 20:50:36 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Mon, 24 Dec 2007 20:46:29 +0100 User-Agent: KMail/1.9.4 References: <20071223210936.GA27776@thorin> In-Reply-To: <20071223210936.GA27776@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712242046.29638.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] colored menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2007 19:46:34 -0000 On Sunday 23 December 2007 22:09, Robert Millan wrote: > This patch adds a nice looking colored menu like the one you'd obtain on > GRUB Legacy with "color cyan/blue white/blue" command. Screenshot is > attached as well. > > A pair of notes: > > - The *_setcolor function stubs are being removed from some terminals > because grub_setcolor() from kernel already skips undefined *_setcolor > implementations so there's no need for an empty stub. In fact, not > needed for this patch but adds confusion (I had to inspect all them to see > if *_getcolor() had to be added). > > - I know that hardcoding colors is not so nice, but I was unsure how > would the selection interface have to look like (and lacking time to > implement it), and in comparison with defaulting to hardcoded 0x07 (grey on > black) I see it as an improvement. I still prefer to keep the default as it is. I like that a user (or a distributor) would modify the colors in grub.cfg. Anyway, this will be a temporary hack, right? I'd love to see a fancier interface built in. Mmh, I really need to allocate time to implement one... Okuji