All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] colored menu
Date: Tue, 25 Dec 2007 10:26:18 +0100	[thread overview]
Message-ID: <20071225092618.GB10985@thorin> (raw)
In-Reply-To: <200712242046.29638.okuji@enbug.org>

On Mon, Dec 24, 2007 at 08:46:29PM +0100, Yoshinori K. Okuji wrote:
> 
> I still prefer to keep the default as it is. I like that a user (or a 
> distributor) would modify the colors in grub.cfg.

Distributors (/me puts Debian hat on) can easily patch it.

Anyway, which interface to use?  It seems to me that env variables would
be more fitting than the "color" command we had in GRUB Legacy.  I suggest
using two: E.g. "menu_normal_color=fg/bg" and "menu_highlight_color=fg/bg",
with the same *color_list[16] from GRUB Legacy.

> Anyway, this will be a temporary hack, right?

No, not really.  That patch will be necessary when colors can be modified in
grub.cfg, too.  The only difference will be that it'll only act based on user
input.

I plan to implement user input too, just not right now.  In the meantime it'd
be nice to have this feature in CVS.  If you like 0x07 / 0x70 more than
0x13 / 0x1f, we can have that as default so that distributors (/me puts debian
hat) can change it easily?

> I'd love to see a fancier 
> interface built in.

Will we have that anytime soon?

> Mmh, I really need to allocate time to implement one...

Would be very nice to see you back on the playground! :-)

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)



  reply	other threads:[~2007-12-25  9:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-23 21:09 [PATCH] colored menu Robert Millan
2007-12-24  1:28 ` Robert Millan
2007-12-24  1:35   ` gfxterm / grub_virtual_screen_setcolorstate() Robert Millan
2007-12-29 23:50     ` Vesa Jääskeläinen
2008-01-23 12:23       ` Marco Gerards
2008-01-23 13:07         ` Robert Millan
2007-12-24 19:46 ` [PATCH] colored menu Yoshinori K. Okuji
2007-12-25  9:26   ` Robert Millan [this message]
2007-12-25 10:27     ` Yoshinori K. Okuji
2007-12-25 11:16       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071225092618.GB10985@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.