All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Badalian Vyacheslav <slavon@bigtelecom.ru>
Cc: netdev@vger.kernel.org
Subject: Re: Strange Panic (Deadlock)
Date: Wed, 26 Dec 2007 19:58:22 +0100	[thread overview]
Message-ID: <20071226185822.GC3061@ami.dom.local> (raw)
In-Reply-To: <20071226185642.GB3061@ami.dom.local>

On Wed, Dec 26, 2007 at 07:56:42PM +0100, Jarek Poplawski wrote:
...

[PATCH 3/3] (for testing only)
---

diff -Nurp linux-2.6.23.12-/net/sched/sch_api.c linux-2.6.23.12+/net/sched/sch_api.c
--- linux-2.6.23.12-/net/sched/sch_api.c	2007-12-21 22:26:15.000000000 +0100
+++ linux-2.6.23.12+/net/sched/sch_api.c	2007-12-26 13:35:46.000000000 +0100
@@ -514,8 +514,11 @@ qdisc_create(struct net_device *dev, u32
 				 * a ops->reset() here? The qdisc was never
 				 * in action so it shouldn't be necessary.
 				 */
-				if (ops->destroy)
+				if (ops->destroy) {
+					qdisc_lock_tree(dev);
 					ops->destroy(sch);
+					qdisc_unlock_tree(dev);
+				}
 				goto err_out3;
 			}
 		}

  reply	other threads:[~2007-12-26 18:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-24 15:12 Strange Panic (Deadlock) Badalian Vyacheslav
2007-12-24 18:18 ` slavon
2007-12-24 20:23   ` Jarek Poplawski
2007-12-25  9:11     ` Badalian Vyacheslav
2007-12-25 14:49       ` Jarek Poplawski
2007-12-25 15:38         ` Denys Fedoryshchenko
2007-12-26 18:54       ` Jarek Poplawski
2007-12-26 18:56         ` Jarek Poplawski
2007-12-26 18:58           ` Jarek Poplawski [this message]
2007-12-27  7:19             ` Jarek Poplawski
2007-12-27 10:03               ` Badalian Vyacheslav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071226185822.GC3061@ami.dom.local \
    --to=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=slavon@bigtelecom.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.