All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: devel@openvz.org, mchan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c
Date: Thu, 27 Dec 2007 16:45:16 -0800 (PST)	[thread overview]
Message-ID: <20071227.164516.236177397.davem@davemloft.net> (raw)
In-Reply-To: <20071227102454.GA14163@iris.sw.ru>

From: "Denis V. Lunev" <den@openvz.org>
Date: Thu, 27 Dec 2007 13:24:54 +0300

> Compilation fix. MAC_FMT is required for
> drivers/net/wireless/libertas/debugfs.c

Putting this public macro back into a header file just
for one driver's debug handling is just rediculious.

I've checked in the following fix instead, thanks.

commit f7b4d3b86615b95b104ca0a95902ca86373a6548
Author: David S. Miller <davem@davemloft.net>
Date:   Thu Dec 27 16:43:38 2007 -0800

    [LIBERTAS]: Remove last stray user of MAC_FMT.
    
    Reported by Denis V. Lunev
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index 0bda0b5..95dd4ed 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -243,7 +243,8 @@ static void libertas_parse_bssid(char *buf, size_t count,
 	if (!hold)
 		return;
 	hold += 6;
-	sscanf(hold, MAC_FMT, mac, mac+1, mac+2, mac+3, mac+4, mac+5);
+	sscanf(hold, "%02x:%02x:%02x:%02x:%02x:%02x",
+	       mac, mac+1, mac+2, mac+3, mac+4, mac+5);
 	memcpy(scan_cfg->bssid, mac, ETH_ALEN);
 }
 

      reply	other threads:[~2007-12-28  0:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-27 10:24 [PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c Denis V. Lunev
2007-12-28  0:45 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071227.164516.236177397.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=den@openvz.org \
    --cc=devel@openvz.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.