Re: [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Thu, Dec 27, 2007 at 01:09:39AM +0000, Carlos Corbacho wrote:
> On Wednesday 26 December 2007 21:17:18 Matthew Garrett wrote:
> > +       if (!wmi_external_handler)
> > +               return AE_ALREADY_ACQUIRED;
> 
> I'm not sure (mostly because I don't like dealing with typedefs around 
> pointers, and this bit is also untested).

At the moment, it's impossible to register a handler - I always get 
AE_ALREADY_ACQUIRED. Getting rid of the ! makes things work like I 
expected.

> > I'm also a bit 
> > unhappy about only being able to register one notification handler, if
> > we consider the case where vendors add and remove WMI interfaces over
> > time - it might make sense to have individual small drivers rather than
> > one big one, which would mean a notification handler per GUID. Any
> > thoughts?
> 
> Yes, a notification handler per GUID does make sense, so I'll add that to WMI.

Excellent, thanks!

-- 
Matthew Garrett | mjg59@srcf.ucam.org