From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] trm290: do hook dma_host_{on,off} methods (take 2)
Date: Thu, 27 Dec 2007 17:05:32 +0100 [thread overview]
Message-ID: <200712271705.32867.bzolnier@gmail.com> (raw)
In-Reply-To: <200712271355.36105.sshtylyov@ru.mvista.com>
On Thursday 27 December 2007, Sergei Shtylyov wrote:
> Using default methods caused the chip's DMA PRD count registers, inadvertently
> starting DMA! While fixing it, also do:
nasty, this could possibly explain the following trm290.c hack:
...
#if 0 /* play it safe for now */
IDE_HFLAG_TRUST_BIOS_FOR_DMA |
#endif
...
> - get rid of the 'ide_' prefixes in several functions for which the prefix in
> the method's name has been 'ide_' ectomized already;
>
> - align the code hooking the IDE DMA methods in init_hwif_trm290()...
>
> ---
> Fixed the header, added 'static' to the new method definitions.
> The patch is against Linus' kernel tree...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
next prev parent reply other threads:[~2007-12-27 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 10:55 [PATCH] trm290: do hook dma_host_{on,off} methods (take 2) Sergei Shtylyov
2007-12-27 16:05 ` Bartlomiej Zolnierkiewicz [this message]
2007-12-28 19:41 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712271705.32867.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.