* [2.6.24 patch] restore Cell OProfile support
@ 2007-12-28 18:56 ` Adrian Bunk
0 siblings, 0 replies; 10+ messages in thread
From: Adrian Bunk @ 2007-12-28 18:56 UTC (permalink / raw)
To: Mathieu Desnoyers, Randy Dunlap, phil.el, paulus
Cc: linuxppc-dev, oprofile-list, linux-kernel
This patch restores the Cell OProfile support that was killed by
commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
kernel/Kconfig.instrumentation | 8 ++++++++
1 file changed, 8 insertions(+)
6d1446d35d367fdbdd2a0a29e0d156646ff40630
diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
index a76635d..9d143e6 100644
--- a/kernel/Kconfig.instrumentation
+++ b/kernel/Kconfig.instrumentation
@@ -53,2 +53,10 @@ config HARDWARE_PM
+config OPROFILE_CELL
+ bool "OProfile for Cell Broadband Engine"
+ depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
+ default y
+ help
+ Profiling of Cell BE SPUs requires special support enabled
+ by this option.
+
config KPROBES
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [2.6.24 patch] restore Cell OProfile support
@ 2007-12-28 18:56 ` Adrian Bunk
0 siblings, 0 replies; 10+ messages in thread
From: Adrian Bunk @ 2007-12-28 18:56 UTC (permalink / raw)
To: Mathieu Desnoyers, Randy Dunlap, phil.el, paulus
Cc: linuxppc-dev, oprofile-list, linux-kernel
This patch restores the Cell OProfile support that was killed by
commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
---
kernel/Kconfig.instrumentation | 8 ++++++++
1 file changed, 8 insertions(+)
6d1446d35d367fdbdd2a0a29e0d156646ff40630
diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
index a76635d..9d143e6 100644
--- a/kernel/Kconfig.instrumentation
+++ b/kernel/Kconfig.instrumentation
@@ -53,2 +53,10 @@ config HARDWARE_PM
+config OPROFILE_CELL
+ bool "OProfile for Cell Broadband Engine"
+ depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
+ default y
+ help
+ Profiling of Cell BE SPUs requires special support enabled
+ by this option.
+
config KPROBES
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] restore Cell OProfile support
2007-12-28 18:56 ` Adrian Bunk
@ 2007-12-28 19:30 ` Mathieu Desnoyers
-1 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2007-12-28 19:30 UTC (permalink / raw)
To: Adrian Bunk
Cc: Randy Dunlap, phil.el, linux-kernel, linuxppc-dev, paulus,
oprofile-list
* Adrian Bunk (adrian.bunk@movial.fi) wrote:
> This patch restores the Cell OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
Same here : why isn't this on by default when SPU_FS and OPROFILE are
enabled ?
> ---
>
> kernel/Kconfig.instrumentation | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> 6d1446d35d367fdbdd2a0a29e0d156646ff40630
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index a76635d..9d143e6 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -53,2 +53,10 @@ config HARDWARE_PM
>
> +config OPROFILE_CELL
> + bool "OProfile for Cell Broadband Engine"
> + depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
> + default y
> + help
> + Profiling of Cell BE SPUs requires special support enabled
> + by this option.
> +
> config KPROBES
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] restore Cell OProfile support
@ 2007-12-28 19:30 ` Mathieu Desnoyers
0 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2007-12-28 19:30 UTC (permalink / raw)
To: Adrian Bunk
Cc: Randy Dunlap, phil.el, paulus, linuxppc-dev, oprofile-list,
linux-kernel
* Adrian Bunk (adrian.bunk@movial.fi) wrote:
> This patch restores the Cell OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
Same here : why isn't this on by default when SPU_FS and OPROFILE are
enabled ?
> ---
>
> kernel/Kconfig.instrumentation | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> 6d1446d35d367fdbdd2a0a29e0d156646ff40630
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index a76635d..9d143e6 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -53,2 +53,10 @@ config HARDWARE_PM
>
> +config OPROFILE_CELL
> + bool "OProfile for Cell Broadband Engine"
> + depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
> + default y
> + help
> + Profiling of Cell BE SPUs requires special support enabled
> + by this option.
> +
> config KPROBES
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
* [2.6.24 patch] Fix Cell OProfile support
2007-12-28 18:56 ` Adrian Bunk
@ 2007-12-29 16:09 ` Mathieu Desnoyers
-1 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2007-12-29 16:09 UTC (permalink / raw)
To: Adrian Bunk
Cc: Randy Dunlap, phil.el, linux-kernel, linuxppc-dev, paulus,
oprofile-list
This patch restores the Cell OProfile support that was killed by
commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
this as a supplementary user-selectable option, it is now automatically enabled
whenever SPU_FS and OPROFILE are enabled.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Adrian Bunk <adrian.bunk@movial.fi>
CC: Randy Dunlap <randy.dunlap@oracle.com>
CC: phil.el@wanadoo.fr
CC: paulus@samba.org
CC: linuxppc-dev@ozlabs.org
CC: oprofile-list@lists.sourceforge.net
---
arch/powerpc/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
Index: linux-2.6-lttng/arch/powerpc/Kconfig
===================================================================
--- linux-2.6-lttng.orig/arch/powerpc/Kconfig 2007-12-28 17:00:24.000000000 -0500
+++ linux-2.6-lttng/arch/powerpc/Kconfig 2007-12-28 17:00:39.000000000 -0500
@@ -163,6 +163,10 @@ config PPC_OF_PLATFORM_PCI
depends on PPC64 # not supported on 32 bits yet
default n
+config OPROFILE_CELL
+ def_bool y
+ depends on (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
+
source "init/Kconfig"
source "arch/powerpc/platforms/Kconfig"
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
* [2.6.24 patch] Fix Cell OProfile support
@ 2007-12-29 16:09 ` Mathieu Desnoyers
0 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2007-12-29 16:09 UTC (permalink / raw)
To: Adrian Bunk
Cc: Randy Dunlap, phil.el, paulus, linuxppc-dev, oprofile-list,
linux-kernel
This patch restores the Cell OProfile support that was killed by
commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
this as a supplementary user-selectable option, it is now automatically enabled
whenever SPU_FS and OPROFILE are enabled.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
CC: Adrian Bunk <adrian.bunk@movial.fi>
CC: Randy Dunlap <randy.dunlap@oracle.com>
CC: phil.el@wanadoo.fr
CC: paulus@samba.org
CC: linuxppc-dev@ozlabs.org
CC: oprofile-list@lists.sourceforge.net
---
arch/powerpc/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
Index: linux-2.6-lttng/arch/powerpc/Kconfig
===================================================================
--- linux-2.6-lttng.orig/arch/powerpc/Kconfig 2007-12-28 17:00:24.000000000 -0500
+++ linux-2.6-lttng/arch/powerpc/Kconfig 2007-12-28 17:00:39.000000000 -0500
@@ -163,6 +163,10 @@ config PPC_OF_PLATFORM_PCI
depends on PPC64 # not supported on 32 bits yet
default n
+config OPROFILE_CELL
+ def_bool y
+ depends on (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
+
source "init/Kconfig"
source "arch/powerpc/platforms/Kconfig"
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] Fix Cell OProfile support
2007-12-29 16:09 ` Mathieu Desnoyers
@ 2007-12-31 16:10 ` Arnd Bergmann
-1 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2007-12-31 16:10 UTC (permalink / raw)
To: linuxppc-dev
Cc: Randy Dunlap, Mathieu Desnoyers, phil.el, linux-kernel, paulus,
oprofile-list, Adrian Bunk
On Saturday 29 December 2007, Mathieu Desnoyers wrote:
> This patch restores the Cell OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
> this as a supplementary user-selectable option, it is now automatically enabled
> whenever SPU_FS and OPROFILE are enabled.
This one has already been superceded by the fix in
aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an
automatically selected option, from arch/powerpc/platforms/cell/Kconfig.
Arnd <><
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] Fix Cell OProfile support
@ 2007-12-31 16:10 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2007-12-31 16:10 UTC (permalink / raw)
To: linuxppc-dev
Cc: Mathieu Desnoyers, Adrian Bunk, Randy Dunlap, phil.el,
linux-kernel, paulus, oprofile-list
On Saturday 29 December 2007, Mathieu Desnoyers wrote:
> This patch restores the Cell OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
> this as a supplementary user-selectable option, it is now automatically enabled
> whenever SPU_FS and OPROFILE are enabled.
This one has already been superceded by the fix in
aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an
automatically selected option, from arch/powerpc/platforms/cell/Kconfig.
Arnd <><
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] Fix Cell OProfile support
2007-12-31 16:10 ` Arnd Bergmann
@ 2008-01-02 17:47 ` Mathieu Desnoyers
-1 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2008-01-02 17:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Randy Dunlap, phil.el, linux-kernel, linuxppc-dev, paulus,
oprofile-list, Adrian Bunk
* Arnd Bergmann (arnd@arndb.de) wrote:
> On Saturday 29 December 2007, Mathieu Desnoyers wrote:
> > This patch restores the Cell OProfile support that was killed by
> > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> >
> > It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
> > this as a supplementary user-selectable option, it is now automatically enabled
> > whenever SPU_FS and OPROFILE are enabled.
>
> This one has already been superceded by the fix in
> aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an
> automatically selected option, from arch/powerpc/platforms/cell/Kconfig.
>
Great, so my patch should be dropped. Thanks!
Mathieu
> Arnd <><
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [2.6.24 patch] Fix Cell OProfile support
@ 2008-01-02 17:47 ` Mathieu Desnoyers
0 siblings, 0 replies; 10+ messages in thread
From: Mathieu Desnoyers @ 2008-01-02 17:47 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linuxppc-dev, Adrian Bunk, Randy Dunlap, phil.el, linux-kernel,
paulus, oprofile-list
* Arnd Bergmann (arnd@arndb.de) wrote:
> On Saturday 29 December 2007, Mathieu Desnoyers wrote:
> > This patch restores the Cell OProfile support that was killed by
> > commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> >
> > It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave
> > this as a supplementary user-selectable option, it is now automatically enabled
> > whenever SPU_FS and OPROFILE are enabled.
>
> This one has already been superceded by the fix in
> aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an
> automatically selected option, from arch/powerpc/platforms/cell/Kconfig.
>
Great, so my patch should be dropped. Thanks!
Mathieu
> Arnd <><
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2008-01-02 17:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-28 18:56 [2.6.24 patch] restore Cell OProfile support Adrian Bunk
2007-12-28 18:56 ` Adrian Bunk
2007-12-28 19:30 ` Mathieu Desnoyers
2007-12-28 19:30 ` Mathieu Desnoyers
2007-12-29 16:09 ` [2.6.24 patch] Fix " Mathieu Desnoyers
2007-12-29 16:09 ` Mathieu Desnoyers
2007-12-31 16:10 ` Arnd Bergmann
2007-12-31 16:10 ` Arnd Bergmann
2008-01-02 17:47 ` Mathieu Desnoyers
2008-01-02 17:47 ` Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.