From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@us.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: kprobes remove fix_riprel #ifdef
Date: Sun, 30 Dec 2007 14:23:37 +0100 [thread overview]
Message-ID: <20071230132337.GF16946@elte.hu> (raw)
In-Reply-To: <47773CAD.7050907@redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Hello Harvey,
>
> A similar idea was already nack-ed by Ananth.
> http://sources.redhat.com/ml/systemtap/2007-q4/msg00468.html
> And I agree his thought.
>
> Especially, "riprel" does not exist on x86_32, so fix_riprel()
> is meaningless on it.
> Thus, I think it would better be ifdef'd in call-site.
but we regularly do this in generic code: we add calls that are NOPs on
some architectures. For example flush_cache_page() makes no sense on the
x86 architecture. So i'm inclined to apply Harvey's cleanup - less
#ifdef complexity in higher-level code is very much favored, even
if "riprel" is a NOP concept on 32-bit.
Ingo
next prev parent reply other threads:[~2007-12-30 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 3:28 [PATCH] x86: kprobes remove fix_riprel #ifdef Harvey Harrison
2007-12-30 6:37 ` Masami Hiramatsu
2007-12-30 13:23 ` Ingo Molnar [this message]
2007-12-30 14:52 ` Masami Hiramatsu
2007-12-30 15:45 ` Ingo Molnar
2007-12-30 20:04 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230132337.GF16946@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.