All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Thomas Gleixner <tglx@linutronix.de>, Andi Kleen <ak@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2
Date: Sun, 30 Dec 2007 15:51:15 +0100	[thread overview]
Message-ID: <20071230145115.GR16946@elte.hu> (raw)
In-Reply-To: <200712291952.20455.yinghai.lu@sun.com>


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> please check if you can replace the one in the x86-mm
> 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76
> 
> the updated one avoid one link warning.

please send delta patches instead - so that we can review the changes.

> this is the updated verison that take enable_IO_APIC as extra call for 
> setup_local_APIC to avoid linking warning.

hm, what link warning did you get? Perhaps the following __cpuinit:

> -void __cpuinit setup_local_APIC (void)

does not mix well with an __init call:

> +void __init enable_IO_APIC(void)

and you hack it around by using a function pointer. Nasty and still 
buggy. The proper solution would be to mark enable_IO_APIC as __cpuinit 
too (or something like that).

	Ingo

  reply	other threads:[~2007-12-30 14:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-30  3:52 [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2 Yinghai Lu
2007-12-30 14:51 ` Ingo Molnar [this message]
2007-12-30 20:48   ` Yinghai Lu
2007-12-30 22:06     ` Adrian Bunk
2007-12-30 22:42       ` Yinghai Lu
2007-12-30 23:23         ` Adrian Bunk
2007-12-31  0:01           ` Yinghai Lu
2007-12-31  0:28             ` Adrian Bunk
2007-12-31  0:56               ` Yinghai Lu
2008-01-01 23:17                 ` Adrian Bunk
2007-12-31  1:03               ` Yinghai Lu
2008-01-01 23:18                 ` Adrian Bunk
2007-12-30 21:30   ` [PATCH] x86_64: fix section warning about enable_IO_APIC and setup_local_APIC Yinghai Lu
2007-12-30 21:29     ` Ingo Molnar
2007-12-30 21:53       ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071230145115.GR16946@elte.hu \
    --to=mingo@elte.hu \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.