All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)
Date: Sun, 30 Dec 2007 15:55:17 +0100	[thread overview]
Message-ID: <20071230145517.GT16946@elte.hu> (raw)
In-Reply-To: <20071230082952.GA12327@uranus.ravnborg.org>


* Sam Ravnborg <sam@ravnborg.org> wrote:

> Combine the 32 and 64 bit specific Makefiles in one file. While doing 
> so link order was (almost) preserved on 32 bit but on 64 bit link 
> order changed a lot.
> 
> Patch was checked with defconfig + allyesconfig builds. The same .o 
> files were linked in these configurations.
> 
> To keep readability of the Makefiles a few Kconfig symbols was 
> added/modified and it was checked that they were not used anywhere 
> else.

hm, i agree with this change, but would it be possible to split this up 
into gradual steps, to change the rules on 64-bit one by one? That would 
make it much more bisectable. In our experience changes to the link 
order have a high likelyhood of breaking stuff, as we've got so many 
implicit initcall dependencies that are not explicitly spelled out.

	Ingo

  reply	other threads:[~2007-12-30 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-30  8:29 [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s) Sam Ravnborg
2007-12-30 14:55 ` Ingo Molnar [this message]
2007-12-30 15:06   ` Ingo Molnar
2007-12-30 16:10     ` Ingo Molnar
2007-12-30 21:19       ` Sam Ravnborg
2007-12-30 21:11     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071230145517.GT16946@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.