All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	trivial@kernel.org, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 1/3] Remove unused dependency
Date: Sun, 30 Dec 2007 23:00:18 +0100	[thread overview]
Message-ID: <20071230220018.GA16557@uranus.ravnborg.org> (raw)
In-Reply-To: <1198351691.4895.42.camel@localhost>

On Sat, Dec 22, 2007 at 11:28:11AM -0800, Joe Perches wrote:
> On Sat, 2007-12-22 at 15:31 +0100, Sam Ravnborg wrote:
> > I looked at how inflate was used:
> >  
> > $ grep inflate */boot/Makefile
> > alpha/boot/Makefile:$(obj)/misc.o: lib/inflate.c
> > => redundandt dependency, can be deleted
> > A cleanup of all this is needed.
> 
> Perhaps it's better to move lib/inflate.c to the
> include path (include/lib ?) and convert the files that
> #include "(../)*lib/inflate.c" to
> #include <lib/inflate.c>?

Hi Joe.

Can you please remind me what problem you are actually trying to solve here.
Your current approach it not good - we do not want .c code in include/*
And what is wrong with the current include path?

Thanks,
	Sam

  reply	other threads:[~2007-12-30 22:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22  7:02 [PATCH 0/3] Remove lib/inflate.c Joe Perches
2007-12-22  7:02 ` [PATCH 1/3] Remove unused dependency Joe Perches
2007-12-22  7:02   ` [PATCH 2/3] " Joe Perches
2007-12-22  7:02     ` [PATCH 3/3] Remove lib/inflate.c Joe Perches
2007-12-22  8:33   ` [PATCH 1/3] Remove unused dependency Sam Ravnborg
2007-12-22  8:50     ` Joe Perches
2007-12-22 14:31       ` Sam Ravnborg
2007-12-22 19:28         ` Joe Perches
2007-12-30 22:00           ` Sam Ravnborg [this message]
2007-12-31  0:16             ` Joe Perches
2007-12-31  8:20               ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071230220018.GA16557@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.