From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9ONJ-0004Ly-2K for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:24:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9ONG-0004LN-VA for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:24:28 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9ONG-0004LF-N8 for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:24:26 -0500 Received: from mis011-2.exch011.intermedia.net ([64.78.21.129]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9ONG-00011J-9k for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:24:26 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C84BCE.D94079F1" Date: Mon, 31 Dec 2007 09:02:08 -0800 Message-ID: <64F9B87B6B770947A9F8391472E0321610055379@ehost011-8.exch011.intermedia.net> From: "Noam Taich" Subject: [Qemu-devel] [PATCH] qemu monitor keyboard functionality Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. ------_=_NextPart_001_01C84BCE.D94079F1 Content-Type: multipart/alternative; boundary="----_=_NextPart_002_01C84BCE.D94079F1" ------_=_NextPart_002_01C84BCE.D94079F1 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable Qemu monitor had many missing keys that could not be (easily) sent,=20 And there was no mechanism for sending strings properly. =20 This patch fixes the problem and enhances the monitor's functionality. ------_=_NextPart_002_01C84BCE.D94079F1 Content-Type: text/html; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable

Qemu monitor had many missing keys that could not be (easily) sent, =

And there was no mechanism for sending strings = properly.

 

This patch fixes the problem and enhances the monitor's = functionality.

------_=_NextPart_002_01C84BCE.D94079F1-- ------_=_NextPart_001_01C84BCE.D94079F1 Content-Type: application/octet-stream; name="qemu-monitor-key-patch.diff" Content-Transfer-Encoding: base64 Content-Description: qemu-monitor-key-patch.diff Content-Disposition: attachment; filename="qemu-monitor-key-patch.diff" LS0tIHFlbXUtc25hcHNob3QtMjAwNy0xMi0zMV8wNS9tb25pdG9yLmMJMjAwNy0xMi0zMSAwNTox MToxMC4wMDAwMDAwMDAgKzAyMDAKKysrIHFlbXUvbW9uaXRvci5jCTIwMDctMTItMzEgMTg6MjQ6 MTQuMDAwMDAwMDAwICswMjAwCkBAIC03NjMsMTE5ICs3NjMsMTg5IEBACiB0eXBlZGVmIHN0cnVj dCB7CiAgICAgaW50IGtleWNvZGU7CiAgICAgY29uc3QgY2hhciAqbmFtZTsKKyAgICBpbnQgbmVl ZF9zaGlmdDsKIH0gS2V5RGVmOwogCiBzdGF0aWMgY29uc3QgS2V5RGVmIGtleV9kZWZzW10gPSB7 Ci0gICAgeyAweDJhLCAic2hpZnQiIH0sCi0gICAgeyAweDM2LCAic2hpZnRfciIgfSwKKyAgICB7 IDB4MmEsICJzaGlmdCIsIDAgfSwKKyAgICB7IDB4MzYsICJzaGlmdF9yIiwgMCB9LAogCi0gICAg eyAweDM4LCAiYWx0IiB9LAotICAgIHsgMHhiOCwgImFsdF9yIiB9LAotICAgIHsgMHgxZCwgImN0 cmwiIH0sCi0gICAgeyAweDlkLCAiY3RybF9yIiB9LAotCi0gICAgeyAweGRkLCAibWVudSIgfSwK LQotICAgIHsgMHgwMSwgImVzYyIgfSwKLQotICAgIHsgMHgwMiwgIjEiIH0sCi0gICAgeyAweDAz LCAiMiIgfSwKLSAgICB7IDB4MDQsICIzIiB9LAotICAgIHsgMHgwNSwgIjQiIH0sCi0gICAgeyAw eDA2LCAiNSIgfSwKLSAgICB7IDB4MDcsICI2IiB9LAotICAgIHsgMHgwOCwgIjciIH0sCi0gICAg eyAweDA5LCAiOCIgfSwKLSAgICB7IDB4MGEsICI5IiB9LAotICAgIHsgMHgwYiwgIjAiIH0sCi0g ICAgeyAweDBjLCAibWludXMiIH0sCi0gICAgeyAweDBkLCAiZXF1YWwiIH0sCi0gICAgeyAweDBl LCAiYmFja3NwYWNlIiB9LAotCi0gICAgeyAweDBmLCAidGFiIiB9LAotICAgIHsgMHgxMCwgInEi IH0sCi0gICAgeyAweDExLCAidyIgfSwKLSAgICB7IDB4MTIsICJlIiB9LAotICAgIHsgMHgxMywg InIiIH0sCi0gICAgeyAweDE0LCAidCIgfSwKLSAgICB7IDB4MTUsICJ5IiB9LAotICAgIHsgMHgx NiwgInUiIH0sCi0gICAgeyAweDE3LCAiaSIgfSwKLSAgICB7IDB4MTgsICJvIiB9LAotICAgIHsg MHgxOSwgInAiIH0sCi0KLSAgICB7IDB4MWMsICJyZXQiIH0sCi0KLSAgICB7IDB4MWUsICJhIiB9 LAotICAgIHsgMHgxZiwgInMiIH0sCi0gICAgeyAweDIwLCAiZCIgfSwKLSAgICB7IDB4MjEsICJm IiB9LAotICAgIHsgMHgyMiwgImciIH0sCi0gICAgeyAweDIzLCAiaCIgfSwKLSAgICB7IDB4MjQs ICJqIiB9LAotICAgIHsgMHgyNSwgImsiIH0sCi0gICAgeyAweDI2LCAibCIgfSwKLQotICAgIHsg MHgyYywgInoiIH0sCi0gICAgeyAweDJkLCAieCIgfSwKLSAgICB7IDB4MmUsICJjIiB9LAotICAg IHsgMHgyZiwgInYiIH0sCi0gICAgeyAweDMwLCAiYiIgfSwKLSAgICB7IDB4MzEsICJuIiB9LAot ICAgIHsgMHgzMiwgIm0iIH0sCi0KLSAgICB7IDB4MzksICJzcGMiIH0sCi0gICAgeyAweDNhLCAi Y2Fwc19sb2NrIiB9LAotICAgIHsgMHgzYiwgImYxIiB9LAotICAgIHsgMHgzYywgImYyIiB9LAot ICAgIHsgMHgzZCwgImYzIiB9LAotICAgIHsgMHgzZSwgImY0IiB9LAotICAgIHsgMHgzZiwgImY1 IiB9LAotICAgIHsgMHg0MCwgImY2IiB9LAotICAgIHsgMHg0MSwgImY3IiB9LAotICAgIHsgMHg0 MiwgImY4IiB9LAotICAgIHsgMHg0MywgImY5IiB9LAotICAgIHsgMHg0NCwgImYxMCIgfSwKLSAg ICB7IDB4NDUsICJudW1fbG9jayIgfSwKLSAgICB7IDB4NDYsICJzY3JvbGxfbG9jayIgfSwKLQot ICAgIHsgMHhiNSwgImtwX2RpdmlkZSIgfSwKLSAgICB7IDB4MzcsICJrcF9tdWx0aXBseSIgfSwK LSAgICB7IDB4NGEsICJrcF9zdWJ0cmFjdCIgfSwKLSAgICB7IDB4NGUsICJrcF9hZGQiIH0sCi0g ICAgeyAweDljLCAia3BfZW50ZXIiIH0sCi0gICAgeyAweDUzLCAia3BfZGVjaW1hbCIgfSwKLQot ICAgIHsgMHg1MiwgImtwXzAiIH0sCi0gICAgeyAweDRmLCAia3BfMSIgfSwKLSAgICB7IDB4NTAs ICJrcF8yIiB9LAotICAgIHsgMHg1MSwgImtwXzMiIH0sCi0gICAgeyAweDRiLCAia3BfNCIgfSwK LSAgICB7IDB4NGMsICJrcF81IiB9LAotICAgIHsgMHg0ZCwgImtwXzYiIH0sCi0gICAgeyAweDQ3 LCAia3BfNyIgfSwKLSAgICB7IDB4NDgsICJrcF84IiB9LAotICAgIHsgMHg0OSwgImtwXzkiIH0s Ci0KLSAgICB7IDB4NTYsICI8IiB9LAotCi0gICAgeyAweDU3LCAiZjExIiB9LAotICAgIHsgMHg1 OCwgImYxMiIgfSwKLQotICAgIHsgMHhiNywgInByaW50IiB9LAotCi0gICAgeyAweGM3LCAiaG9t ZSIgfSwKLSAgICB7IDB4YzksICJwZ3VwIiB9LAotICAgIHsgMHhkMSwgInBnZG4iIH0sCi0gICAg eyAweGNmLCAiZW5kIiB9LAotCi0gICAgeyAweGNiLCAibGVmdCIgfSwKLSAgICB7IDB4YzgsICJ1 cCIgfSwKLSAgICB7IDB4ZDAsICJkb3duIiB9LAotICAgIHsgMHhjZCwgInJpZ2h0IiB9LAorICAg IHsgMHgzOCwgImFsdCIsIDAgfSwKKyAgICB7IDB4YjgsICJhbHRfciIsIDAgfSwKKyAgICB7IDB4 MWQsICJjdHJsIiwgMCB9LAorICAgIHsgMHg5ZCwgImN0cmxfciIsIDAgfSwKKworICAgIHsgMHhk ZCwgIm1lbnUiLCAwIH0sCisKKyAgICB7IDB4MDEsICJlc2MiLCAwIH0sCisKKyAgICB7IDB4MDIs ICIxIiwgMCB9LAorICAgIHsgMHgwMywgIjIiLCAwIH0sCisgICAgeyAweDA0LCAiMyIsIDAgfSwK KyAgICB7IDB4MDUsICI0IiwgMCB9LAorICAgIHsgMHgwNiwgIjUiLCAwIH0sCisgICAgeyAweDA3 LCAiNiIsIDAgfSwKKyAgICB7IDB4MDgsICI3IiwgMCB9LAorICAgIHsgMHgwOSwgIjgiLCAwIH0s CisgICAgeyAweDBhLCAiOSIsIDAgfSwKKyAgICB7IDB4MGIsICIwIiwgMCB9LAorCisgICAgeyAw eDAyLCAiISIsIDEgfSwKKyAgICB7IDB4MDMsICJAIiwgMSB9LAorICAgIHsgMHgwNCwgIiMiLCAx IH0sCisgICAgeyAweDA1LCAiJCIsIDEgfSwKKyAgICB7IDB4MDYsICIlIiwgMSB9LAorICAgIHsg MHgwNywgIl4iLCAxIH0sCisgICAgeyAweDA4LCAiJiIsIDEgfSwKKyAgICB7IDB4MDksICIqIiwg MSB9LAorICAgIHsgMHgwYSwgIigiLCAxIH0sCisgICAgeyAweDBiLCAiKSIsIDEgfSwKKworICAg IHsgMHgwYywgIm1pbnVzIiwgMCB9LAorICAgIHsgMHgwZCwgImVxdWFsIiwgMCB9LAorICAgIHsg MHgwZCwgIj0iLCAwIH0sCisgICAgeyAweDBlLCAiYmFja3NwYWNlIiwgMCB9LAorCisgICAgeyAw eDBjLCAiXyIsIDEgfSwKKworICAgIHsgMHgwZiwgInRhYiIsIDAgfSwKKyAgICB7IDB4MTAsICJx IiwgMCB9LAorICAgIHsgMHgxMSwgInciLCAwIH0sCisgICAgeyAweDEyLCAiZSIsIDAgfSwKKyAg ICB7IDB4MTMsICJyIiwgMCB9LAorICAgIHsgMHgxNCwgInQiLCAwIH0sCisgICAgeyAweDE1LCAi eSIsIDAgfSwKKyAgICB7IDB4MTYsICJ1IiwgMCB9LAorICAgIHsgMHgxNywgImkiLCAwIH0sCisg ICAgeyAweDE4LCAibyIsIDAgfSwKKyAgICB7IDB4MTksICJwIiwgMCB9LAorCisgICAgeyAweDFj LCAicmV0IiwgMCB9LAorCisgICAgeyAweDFlLCAiYSIsIDAgfSwKKyAgICB7IDB4MWYsICJzIiwg MCB9LAorICAgIHsgMHgyMCwgImQiLCAwIH0sCisgICAgeyAweDIxLCAiZiIsIDAgfSwKKyAgICB7 IDB4MjIsICJnIiwgMCB9LAorICAgIHsgMHgyMywgImgiLCAwIH0sCisgICAgeyAweDI0LCAiaiIs IDAgfSwKKyAgICB7IDB4MjUsICJrIiwgMCB9LAorICAgIHsgMHgyNiwgImwiLCAwIH0sCisKKyAg ICB7IDB4MmMsICJ6IiwgMCB9LAorICAgIHsgMHgyZCwgIngiLCAwIH0sCisgICAgeyAweDJlLCAi YyIsIDAgfSwKKyAgICB7IDB4MmYsICJ2IiwgMCB9LAorICAgIHsgMHgzMCwgImIiLCAwIH0sCisg ICAgeyAweDMxLCAibiIsIDAgfSwKKyAgICB7IDB4MzIsICJtIiwgMCB9LAorCisgICAgeyAweDEw LCAiUSIsIDEgfSwKKyAgICB7IDB4MTEsICJXIiwgMSB9LAorICAgIHsgMHgxMiwgIkUiLCAxIH0s CisgICAgeyAweDEzLCAiUiIsIDEgfSwKKyAgICB7IDB4MTQsICJUIiwgMSB9LAorICAgIHsgMHgx NSwgIlkiLCAxIH0sCisgICAgeyAweDE2LCAiVSIsIDEgfSwKKyAgICB7IDB4MTcsICJJIiwgMSB9 LAorICAgIHsgMHgxOCwgIk8iLCAxIH0sCisgICAgeyAweDE5LCAiUCIsIDEgfSwKKworICAgIHsg MHgxZSwgIkEiLCAxIH0sCisgICAgeyAweDFmLCAiUyIsIDEgfSwKKyAgICB7IDB4MjAsICJEIiwg MSB9LAorICAgIHsgMHgyMSwgIkYiLCAxIH0sCisgICAgeyAweDIyLCAiRyIsIDEgfSwKKyAgICB7 IDB4MjMsICJIIiwgMSB9LAorICAgIHsgMHgyNCwgIkoiLCAxIH0sCisgICAgeyAweDI1LCAiSyIs IDEgfSwKKyAgICB7IDB4MjYsICJMIiwgMSB9LAorCisgICAgeyAweDJjLCAiWiIsIDEgfSwKKyAg ICB7IDB4MmQsICJYIiwgMSB9LAorICAgIHsgMHgyZSwgIkMiLCAxIH0sCisgICAgeyAweDJmLCAi ViIsIDEgfSwKKyAgICB7IDB4MzAsICJCIiwgMSB9LAorICAgIHsgMHgzMSwgIk4iLCAxIH0sCisg ICAgeyAweDMyLCAiTSIsIDEgfSwKKworCisgICAgeyAweDFhLCAiWyIsIDAgfSwKKyAgICB7IDB4 MWIsICJdIiwgMCB9LAorICAgIHsgMHgxYSwgInsiLCAxIH0sCisgICAgeyAweDFiLCAifSIsIDEg fSwKKworICAgIHsgMHgyNywgIjsiLCAwIH0sCisgICAgeyAweDI4LCAiJyIsIDAgfSwKKyAgICB7 IDB4MjksICJgIiwgMCB9LAorICAgIHsgMHgyYiwgIlxcIiwgMCB9LAorCisgICAgeyAweDI3LCAi OiIsIDEgfSwKKyAgICB7IDB4MjgsICJcIiIsIDEgfSwKKyAgICB7IDB4MjksICJ+IiwgMSB9LAor ICAgIHsgMHgyYiwgInwiLCAxIH0sCisKKyAgICB7IDB4MzMsICIsIiwgMCB9LAorICAgIHsgMHgz NCwgIi4iLCAwIH0sCisgICAgeyAweDM1LCAiLyIsIDAgfSwKKyAgICB7IDB4MzMsICI8IiwgMSB9 LAorICAgIHsgMHgzNCwgIj4iLCAxIH0sCisgICAgeyAweDM1LCAiPyIsIDEgfSwKKworICAgIHsg MHgzOSwgInNwYyIsIDAgfSwKKyAgICB7IDB4MzksICIgIiwgMCB9LAorICAgIHsgMHgzYSwgImNh cHNfbG9jayIsIDAgfSwKKyAgICB7IDB4M2IsICJmMSIsIDAgfSwKKyAgICB7IDB4M2MsICJmMiIs IDAgfSwKKyAgICB7IDB4M2QsICJmMyIsIDAgfSwKKyAgICB7IDB4M2UsICJmNCIsIDAgfSwKKyAg ICB7IDB4M2YsICJmNSIsIDAgfSwKKyAgICB7IDB4NDAsICJmNiIsIDAgfSwKKyAgICB7IDB4NDEs ICJmNyIsIDAgfSwKKyAgICB7IDB4NDIsICJmOCIsIDAgfSwKKyAgICB7IDB4NDMsICJmOSIsIDAg fSwKKyAgICB7IDB4NDQsICJmMTAiLCAwIH0sCisgICAgeyAweDQ1LCAibnVtX2xvY2siLCAwIH0s CisgICAgeyAweDQ2LCAic2Nyb2xsX2xvY2siLCAwIH0sCisKKyAgICB7IDB4NGEsICItIiwgMH0s CisgICAgeyAweDRlLCAiKyIsIDB9LAorCisgICAgeyAweGI1LCAia3BfZGl2aWRlIiwgMCB9LAor ICAgIHsgMHgzNywgImtwX211bHRpcGx5IiwgMCB9LAorICAgIHsgMHg0YSwgImtwX3N1YnRyYWN0 IiwgMCB9LAorICAgIHsgMHg0ZSwgImtwX2FkZCIsIDAgfSwKKyAgICB7IDB4OWMsICJrcF9lbnRl ciIsIDAgfSwKKyAgICB7IDB4NTMsICJrcF9kZWNpbWFsIiwgMCB9LAorCisgICAgeyAweDUyLCAi a3BfMCIsIDAgfSwKKyAgICB7IDB4NGYsICJrcF8xIiwgMCB9LAorICAgIHsgMHg1MCwgImtwXzIi LCAwIH0sCisgICAgeyAweDUxLCAia3BfMyIsIDAgfSwKKyAgICB7IDB4NGIsICJrcF80IiwgMCB9 LAorICAgIHsgMHg0YywgImtwXzUiLCAwIH0sCisgICAgeyAweDRkLCAia3BfNiIsIDAgfSwKKyAg ICB7IDB4NDcsICJrcF83IiwgMCB9LAorICAgIHsgMHg0OCwgImtwXzgiLCAwIH0sCisgICAgeyAw eDQ5LCAia3BfOSIsIDAgfSwKKworICAgIHsgMHg1NywgImYxMSIsIDAgfSwKKyAgICB7IDB4NTgs ICJmMTIiLCAwIH0sCisKKyAgICB7IDB4YjcsICJwcmludCIsIDAgfSwKKworICAgIHsgMHhjNywg ImhvbWUiLCAwIH0sCisgICAgeyAweGM5LCAicGd1cCIsIDAgfSwKKyAgICB7IDB4ZDEsICJwZ2Ru IiwgMCB9LAorICAgIHsgMHhjZiwgImVuZCIsIDAgfSwKKworICAgIHsgMHhjYiwgImxlZnQiLCAw IH0sCisgICAgeyAweGM4LCAidXAiLCAwIH0sCisgICAgeyAweGQwLCAiZG93biIsIDAgfSwKKyAg ICB7IDB4Y2QsICJyaWdodCIsIDAgfSwKIAotICAgIHsgMHhkMiwgImluc2VydCIgfSwKLSAgICB7 IDB4ZDMsICJkZWxldGUiIH0sCisgICAgeyAweGQyLCAiaW5zZXJ0IiwgMCB9LAorICAgIHsgMHhk MywgImRlbGV0ZSIsIDAgfSwKICAgICB7IDAsIE5VTEwgfSwKIH07CiAKQEAgLTg5Nyw2ICs5Njcs MTcgQEAKICAgICByZXR1cm4gLTE7CiB9CiAKK3N0YXRpYyBpbnQgaXNfc2hpZnRfbmVlZGVkKGNv bnN0IGNoYXIgKmtleSkKK3sKKyAgICBjb25zdCBLZXlEZWYgKnA7CisKKyAgICBmb3IocCA9IGtl eV9kZWZzOyBwLT5uYW1lICE9IE5VTEw7IHArKykgeworICAgICAgICBpZiAoIXN0cmNtcChrZXks IHAtPm5hbWUpKQorICAgICAgICAgICAgcmV0dXJuIHAtPm5lZWRfc2hpZnQ7CisgICAgfQorICAg IHJldHVybiAtMTsKK30KKwogc3RhdGljIHZvaWQgZG9fc2VuZF9rZXkoY29uc3QgY2hhciAqc3Ry aW5nKQogewogICAgIGNoYXIga2V5YnVmWzE2XSwgKnE7CkBAIC05NDEsNiArMTAyMiw1MCBAQAog ICAgIH0KIH0KIAorc3RhdGljIHZvaWQgZG9fc2VuZF9zdHJpbmcoY29uc3QgY2hhciAqc3RyKQor eworICAgIGNoYXIga2V5YnVmWzJdOworICAgIGNvbnN0IGNoYXIgKnAgPSBzdHI7CisgICAgaW50 IGtleWNvZGU7CisKKyAgICBrZXlidWZbMF0gPSAnXDAnOworICAgIGtleWJ1ZlsxXSA9ICdcMCc7 CisKKyAgICB3aGlsZSAoKnAgIT0gJ1wwJykgeworICAgICAgICBrZXlidWZbMF0gPSAqcDsKKyAg ICAgICAga2V5Y29kZSA9IGdldF9rZXljb2RlKGtleWJ1Zik7CisgICAgICAgIGludCBzaGlmdF9u ZWVkZWQgPSBpc19zaGlmdF9uZWVkZWQoa2V5YnVmKTsKKyAgICAgICAgaWYgKGtleWNvZGUgPCAw KSB7CisgICAgICAgICAgICB0ZXJtX3ByaW50ZigidW5rbm93biBrZXk6ICclcydcbiIsIGtleWJ1 Zik7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICAvLyBQcmVzcyBz aGlmdCBpZiBuZWVkZWQKKyAgICAgICAgaWYgKHNoaWZ0X25lZWRlZCkKKyAgICAgICAgeworICAg ICAgICAgICAga2JkX3B1dF9rZXljb2RlKDB4MmEgJiAweDdmKTsKKyAgICAgICAgfQorCisgICAg ICAgIC8vIEtleSBkb3duIGV2ZW50CisgICAgICAgIGlmIChrZXljb2RlICYgMHg4MCkKKyAgICAg ICAgICAgIGtiZF9wdXRfa2V5Y29kZSgweGUwKTsKKyAgICAgICAga2JkX3B1dF9rZXljb2RlKGtl eWNvZGUgJiAweDdmKTsKKworICAgICAgICAvLyBLZXkgdXAgZXZlbnQKKyAgICAgICAgaWYgKGtl eWNvZGUgJiAweDgwKQorICAgICAgICAgICAga2JkX3B1dF9rZXljb2RlKDB4ZTApOworICAgICAg ICBrYmRfcHV0X2tleWNvZGUoa2V5Y29kZSB8IDB4ODApOworCisgICAgICAgIC8vIFJlbGVhc2Ug c2hpZnQgaWYgbmVlZGVkCisgICAgICAgIGlmIChzaGlmdF9uZWVkZWQpCisgICAgICAgIHsKKyAg ICAgICAgICAgIGtiZF9wdXRfa2V5Y29kZSgweDJhIHwgMHg4MCk7CisgICAgICAgIH0KKworICAg ICAgICBwKys7CisgICAgfQorfQorCiBzdGF0aWMgaW50IG1vdXNlX2J1dHRvbl9zdGF0ZTsKIAog c3RhdGljIHZvaWQgZG9fbW91c2VfbW92ZShjb25zdCBjaGFyICpkeF9zdHIsIGNvbnN0IGNoYXIg KmR5X3N0ciwKQEAgLTEyOTksNiArMTQyNCw4IEBACiAKICAgICB7ICJzZW5ka2V5IiwgInMiLCBk b19zZW5kX2tleSwKICAgICAgICJrZXlzIiwgInNlbmQga2V5cyB0byB0aGUgVk0gKGUuZy4gJ3Nl bmRrZXkgY3RybC1hbHQtZjEnKSIgfSwKKyAgICB7ICJzZW5kc3RyaW5nIiwgInMiLCBkb19zZW5k X3N0cmluZywKKyAgICAgICJzdHJpbmciLCAic2VuZCBzdHJpbmdzIHRvIHRoZSBWTSAoZS5nLiAn c2VuZHN0cmluZyBhYmMnKSIgfSwKICAgICB7ICJzeXN0ZW1fcmVzZXQiLCAiIiwgZG9fc3lzdGVt X3Jlc2V0LAogICAgICAgIiIsICJyZXNldCB0aGUgc3lzdGVtIiB9LAogICAgIHsgInN5c3RlbV9w b3dlcmRvd24iLCAiIiwgZG9fc3lzdGVtX3Bvd2VyZG93biwK ------_=_NextPart_001_01C84BCE.D94079F1-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9Ohz-00035h-O3 for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:45:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9Ohy-000352-Ub for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:45:51 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9Ohy-00034s-Rc for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:45:50 -0500 Received: from smtp02.citrix.com ([66.165.176.63]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9Ohy-00060D-J3 for qemu-devel@nongnu.org; Mon, 31 Dec 2007 12:45:50 -0500 Received: from implementation.famille.thibault.fr (dhcp-16-192.uk.xensource.com [172.31.16.192]) by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id lBVHj4eS029316 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 31 Dec 2007 09:45:06 -0800 Received: from samy by implementation.famille.thibault.fr with local (Exim 4.68) (envelope-from ) id 1J9OhD-0002QW-FI for qemu-devel@nongnu.org; Mon, 31 Dec 2007 18:45:03 +0100 Date: Mon, 31 Dec 2007 17:45:03 +0000 From: Samuel Thibault Subject: Re: [Qemu-devel] [PATCH] qemu monitor keyboard functionality Message-ID: <20071231174503.GG5447@implementation.uk.xensource.com> References: <64F9B87B6B770947A9F8391472E0321610055379@ehost011-8.exch011.intermedia.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <64F9B87B6B770947A9F8391472E0321610055379@ehost011-8.exch011.intermedia.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Noam Taich, le Mon 31 Dec 2007 09:02:08 -0800, a écrit : > Qemu monitor had many missing keys that could not be (easily) sent, > > And there was no mechanism for sending strings properly. > > This patch fixes the problem and enhances the monitor's functionality. Mmm, isn't there a keyboard layout issue? Far from all keyboards are US qwerty... Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9P3L-0000Kk-Au for qemu-devel@nongnu.org; Mon, 31 Dec 2007 13:07:55 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9P3J-0000KY-To for qemu-devel@nongnu.org; Mon, 31 Dec 2007 13:07:55 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9P3J-0000KV-OC for qemu-devel@nongnu.org; Mon, 31 Dec 2007 13:07:53 -0500 Received: from mis011-2.exch011.intermedia.net ([64.78.21.129]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J9P3J-0000rJ-Ad for qemu-devel@nongnu.org; Mon, 31 Dec 2007 13:07:53 -0500 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: [Qemu-devel] [PATCH] qemu monitor keyboard functionality Date: Mon, 31 Dec 2007 10:08:04 -0800 Message-ID: <64F9B87B6B770947A9F8391472E03216100553CA@ehost011-8.exch011.intermedia.net> In-Reply-To: <20071231174503.GG5447@implementation.uk.xensource.com> References: <64F9B87B6B770947A9F8391472E0321610055379@ehost011-8.exch011.intermedia.net> <20071231174503.GG5447@implementation.uk.xensource.com> From: "Noam Taich" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org That would only mean that the monitor was suffering from the same = problem before the patch, since the keys that were supported before were = already layout-specific. The patch does not intend to change the way the monitor works and = improve its localization and internationalization support, just to = extend existing functionalities. More keys were added to the monitor using the layout that the existing = keys were using. Indeed, in the future it would be nice to have multiple keyboard layout = support, which is indeed lacking right now, but for now, the monitor = does not supply support for this, and was simply lacking many keys in = what it does support, which is a much bigger problem. So this patch is a step in the right direction. This is as far as specific keys are concerned, The "sendstring" addition seems to be just an important thing to have, = and it is a bit useless with that many keys missing anyway. -----Original Message----- From: qemu-devel-bounces+noam.taich=3Dqumranet.com@nongnu.org = [mailto:qemu-devel-bounces+noam.taich=3Dqumranet.com@nongnu.org] On = Behalf Of Samuel Thibault Sent: Monday, December 31, 2007 7:45 PM To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] qemu monitor keyboard functionality Noam Taich, le Mon 31 Dec 2007 09:02:08 -0800, a =E9crit : > Qemu monitor had many missing keys that could not be (easily) sent, >=20 > And there was no mechanism for sending strings properly. >=20 > This patch fixes the problem and enhances the monitor's functionality. Mmm, isn't there a keyboard layout issue? Far from all keyboards are US qwerty... Samuel