From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 00/40] svc: SVC Transport Switch
Date: Mon, 31 Dec 2007 17:13:36 -0500 [thread overview]
Message-ID: <20071231221336.GA26470@fieldses.org> (raw)
In-Reply-To: <20071231030712.8430.45576.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
On Sun, Dec 30, 2007 at 09:07:12PM -0600, Tom Tucker wrote:
>
> The Server Side Transport switch implements a pluggable transport
> provider layer for RPC servers. This allows network transport drivers
> to be dynamically loaded and registered, thereby extending the set of
> transports that can carry RPC. This patchset includes a transport
> provider driver for TCP and UDP sockets.
>
>
> This version of the patchset is functionally equivalent to the
> preceding patchset and includes the following improvements:
Thanks! Got it.
--b.
>
> - Fixed a bug in svc_create_socket that resulted in svc_xprt_received
> being called without holding the XPT_BUSY bit.
>
> - Added a BUG_ON in svc_xprt_received to catch providers calling
> svc_xprt_received without holding the XPT_BUSY bit.
>
> - Removed code setting the XPT_BUSY bit in the create path and moved
> this logic to common code.
>
> - Cleaned up the SMP locking strategy comment and moved it to
> svc_xprt.c
>
> - Changed return type of svc_unreg_xprt_class to void
>
> - Simplified transport class removal logic
>
> - Fixed a white-space abuse issue
>
> - Made some style changes to the patch comments
>
> - Created a separate patch that moves the connection limit code to
> generic logic
>
> - Created a separate patch that moves the call to svc_xprt_received
> out of tcp_accept and into common logic
>
> - Created a separate patch for removal of unnecessary call to
> svc_sock_enqueue in svc_tcp_accept function
>
> - Removed silly BUG_ON from kref svc_xprt_free callback function
>
> - Moved unlock of svc_xprt_class list to after the try_module_lock
> call.
>
> - Refactored svc_create_xprt logic
>
> - Removed unnecessary call to svc_find_xprt in portlist code
>
> --
> Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
prev parent reply other threads:[~2007-12-31 22:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 3:07 [PATCH 00/40] svc: SVC Transport Switch Tom Tucker
[not found] ` <20071231030712.8430.45576.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-31 3:07 ` [PATCH 01/40] svc: Add an svc transport class Tom Tucker
2007-12-31 3:07 ` [PATCH 02/40] svc: Make svc_sock the tcp/udp transport Tom Tucker
2007-12-31 3:07 ` [PATCH 03/40] svc: Change the svc_sock in the rqstp structure to a transport Tom Tucker
2007-12-31 3:07 ` [PATCH 04/40] svc: Add a max payload value to the transport Tom Tucker
2007-12-31 3:07 ` [PATCH 05/40] svc: Move sk_sendto and sk_recvfrom to svc_xprt_class Tom Tucker
2007-12-31 3:07 ` [PATCH 06/40] svc: Add transport specific xpo_release function Tom Tucker
2007-12-31 3:07 ` [PATCH 07/40] svc: Add per-transport delete functions Tom Tucker
2007-12-31 3:07 ` [PATCH 08/40] svc: Add xpo_prep_reply_hdr Tom Tucker
2007-12-31 3:07 ` [PATCH 09/40] svc: Add a transport function that checks for write space Tom Tucker
2007-12-31 3:07 ` [PATCH 10/40] svc: Move close processing to a single place Tom Tucker
2007-12-31 3:07 ` [PATCH 11/40] svc: Add xpo_accept transport function Tom Tucker
2007-12-31 3:07 ` [PATCH 12/40] svc: Remove unnecessary call to svc_sock_enqueue Tom Tucker
2007-12-31 3:07 ` [PATCH 13/40] svc: Move connection limit checking to its own function Tom Tucker
2007-12-31 3:07 ` [PATCH 14/40] svc: Add a generic transport svc_create_xprt function Tom Tucker
2007-12-31 3:07 ` [PATCH 15/40] svc: Change services to use new svc_create_xprt service Tom Tucker
2007-12-31 3:07 ` [PATCH 16/40] svc: Change sk_inuse to a kref Tom Tucker
2007-12-31 3:07 ` [PATCH 17/40] svc: Move sk_flags to the svc_xprt structure Tom Tucker
2007-12-31 3:07 ` [PATCH 18/40] svc: Move sk_server and sk_pool to svc_xprt Tom Tucker
2007-12-31 3:07 ` [PATCH 19/40] svc: Make close transport independent Tom Tucker
2007-12-31 3:07 ` [PATCH 20/40] svc: Move sk_reserved to svc_xprt Tom Tucker
2007-12-31 3:07 ` [PATCH 21/40] svc: Make the enqueue service transport neutral and export it Tom Tucker
2007-12-31 3:07 ` [PATCH 22/40] svc: Make svc_send transport neutral Tom Tucker
2007-12-31 3:08 ` [PATCH 23/40] svc: Change svc_sock_received to svc_xprt_received and export it Tom Tucker
2007-12-31 3:08 ` [PATCH 24/40] svc: Move accept call to svc_xprt_received to common code Tom Tucker
2007-12-31 3:08 ` [PATCH 25/40] svc: Remove sk_lastrecv Tom Tucker
2007-12-31 3:08 ` [PATCH 26/40] svc: Move the authinfo cache to svc_xprt Tom Tucker
2007-12-31 3:08 ` [PATCH 27/40] svc: Make deferral processing xprt independent Tom Tucker
2007-12-31 3:08 ` [PATCH 28/40] svc: Move the sockaddr information to svc_xprt Tom Tucker
2007-12-31 3:08 ` [PATCH 29/40] svc: Make svc_sock_release svc_xprt_release Tom Tucker
2007-12-31 3:08 ` [PATCH 30/40] svc: Make svc_recv transport neutral Tom Tucker
2007-12-31 3:08 ` [PATCH 31/40] svc: Make svc_age_temp_sockets svc_age_temp_transports Tom Tucker
2007-12-31 3:08 ` [PATCH 32/40] svc: Move create logic to common code Tom Tucker
2007-12-31 3:08 ` [PATCH 33/40] svc: Removing remaining references to rq_sock in rqstp Tom Tucker
2007-12-31 3:08 ` [PATCH 34/40] svc: Make svc_check_conn_limits xprt independent Tom Tucker
2007-12-31 3:08 ` [PATCH 35/40] svc: Move the xprt independent code to the svc_xprt.c file Tom Tucker
[not found] ` <20071231030827.8430.76850.stgit-gUwIgmpLGaKNDNWfRnPdfg@public.gmane.org>
2007-12-31 22:14 ` J. Bruce Fields
2007-12-31 3:08 ` [PATCH 36/40] svc: Add transport hdr size for defer/revisit Tom Tucker
2007-12-31 3:08 ` [PATCH 37/40] svc: Add /proc/sys/sunrpc/transport files Tom Tucker
2007-12-31 3:08 ` [PATCH 38/40] svc: Add svc API that queries for a transport instance Tom Tucker
2007-12-31 3:08 ` [PATCH 39/40] knfsd: Support adding transports by writing portlist file Tom Tucker
2007-12-31 3:08 ` [PATCH 40/40] svc: Add svc_xprt_names service to replace svc_sock_names Tom Tucker
2007-12-31 22:13 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071231221336.GA26470@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.