All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Alan Cox <alan@redhat.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
	John Levon <moz@compsoc.man.ac.uk>,
	Linus Torvalds <torvalds@transmeta.com>,
	linux-kernel@vger.kernel.org, faith@valinux.com,
	jhartmann@precisioninsight.com
Subject: Re: [PATCH] Make agpsupport work with modversions
Date: Fri, 27 Oct 2000 14:25:48 +0100	[thread overview]
Message-ID: <20075.972653148@redhat.com> (raw)
In-Reply-To: <20001027005500.A11447@suse.cz>
In-Reply-To: <20001027005500.A11447@suse.cz>  <20001019102722.B9057@suse.cz> <200010262221.e9QMLfC32276@devserv.devel.redhat.com>


vojtech@suse.cz said:
> > But that module then depends on both of the others unless you keep
> > recompiling it

> Not really, see for example ns558.c and adi.c plus their third module
> gameport.c, all in drivers/char/joystick. 

But in the case where there _aren't_ any functions which could usefully be 
shared between the modules, you've got a whole extra gratuitous module 
(What's that, 32KiB on some ARM boxen?) just to hold the registration 
functions, which aren't needed if you just use get_module_symbol().

Provide generic code for registering such stuff and it might be acceptable. 
Otherwise, get_module_symbol is better. There's no fundamental flaw with 
get_module_symbol() - just one or two of the current usages of it.

--
dwmw2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  parent reply	other threads:[~2000-10-27 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20001019102722.B9057@suse.cz>
2000-10-26 22:21 ` [PATCH] Make agpsupport work with modversions Alan Cox
2000-10-26 22:55   ` Vojtech Pavlik
2000-10-27 13:25   ` David Woodhouse [this message]
2000-10-28  2:18     ` Keith Owens
2000-10-28  6:58       ` Andrew Morton
2000-10-28  9:40       ` Alan Cox
2000-10-28  9:55         ` Keith Owens
2000-10-28 10:07           ` Alan Cox
2000-10-28 10:02       ` Alan Cox
2000-10-28 10:08         ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20075.972653148@redhat.com \
    --to=dwmw2@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alan@redhat.com \
    --cc=faith@valinux.com \
    --cc=jhartmann@precisioninsight.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moz@compsoc.man.ac.uk \
    --cc=torvalds@transmeta.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.