From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: Re: [PATCH 2/3 v2] vpmu intel: Use PMU defines instead
	of numerals and bit masks
Date: Thu, 04 Apr 2013 14:10:18 +0200
Message-ID: <20079614.5xvBTPi963@amur>
References: <1452239.A5Lgmt1kI0@amur>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1452239.A5Lgmt1kI0@amur>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
Cc: Eddie Dong <eddie.dong@intel.com>, Jun Nakajima <jun.nakajima@intel.com>, suravee.suthikulpanit@amd.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

QW0gRG9ubmVyc3RhZyAyOCBNw6RyeiAyMDEzLCAxMzo1Nzo1MCBzY2hyaWViIERpZXRtYXIgSGFo
bjoKPiBUaGlzIHBhdGNoIHVzZXMgdGhlIG5ldyBkZWZpbmVzIGluIEludGVsIHZQTVUgdG8gcmVw
bGFjZSBleGlzdGluZyBudW1lcmFscyBhbmQKPiBiaXQgbWFza3MuCj4gVGhhbmtzLAo+IERpZXRt
YXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGlldG1hciBIYWhuIDxkaWV0bWFyLmhhaG5AdHMuZnVq
aXRzdS5jb20+CgpQaW5nPwogCj4gQ2hhbmdlcyBmcm9tIHYxOiBBcyBLb25yYWQgc3VnZ2VzdGVk
IHRoZSBuYW1lcyBvZiB0aGUgZGVmaW5lcyBhcmUgY2hhbmdlZCB0b28KPiAgICAgICAgICAgICAg
ICAgIGFuZCB0aGUgcmVhZGFiaWxpdHkgaXMgbXVjaCBiZXR0ZXIgbm93Lgo+IAo+IAo+IC0tLSBh
L3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZwbXVfY29yZTIuYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9o
dm0vdm14L3ZwbXVfY29yZTIuYwo+IEBAIC0zOSw2ICszOSwzMiBAQAo+ICAjaW5jbHVkZSA8YXNt
L2h2bS92bXgvdnBtdV9jb3JlMi5oPgo+ICAKPiAgLyoKPiArICogU2VlIEludGVsIFNETSBWb2wg
MmEgSW5zdHJ1Y3Rpb24gU2V0IFJlZmVyZW5jZSBjaGFwdGVyIDMgZm9yIENQVUlECj4gKyAqIGlu
c3RydWN0aW9uLgo+ICsgKiBjcHVpZCAweGEgLSBBcmNoaXRlY3R1cmFsIFBlcmZvcm1hbmNlIE1v
bml0b3JpbmcgTGVhZgo+ICsgKiBSZWdpc3RlciBlYXgKPiArICovCj4gKyNkZWZpbmUgUE1VX1ZF
UlNJT05fU0hJRlQgICAgICAgIDAgIC8qIFZlcnNpb24gSUQgKi8KPiArI2RlZmluZSBQTVVfVkVS
U0lPTl9CSVRTICAgICAgICAgOCAgLyogOCBiaXRzIDAuLjcgKi8KPiArI2RlZmluZSBQTVVfVkVS
U0lPTl9NQVNLICAgICAgICAgKCgoMSA8PCBQTVVfVkVSU0lPTl9CSVRTKSAtIDEpIDw8IFBNVV9W
RVJTSU9OX1NISUZUKQo+ICsKPiArI2RlZmluZSBQTVVfR0VORVJBTF9OUl9TSElGVCAgICAgOCAg
LyogTnVtYmVyIG9mIGdlbmVyYWwgcG11IHJlZ2lzdGVycyAqLwo+ICsjZGVmaW5lIFBNVV9HRU5F
UkFMX05SX0JJVFMgICAgICA4ICAvKiA4IGJpdHMgOC4uMTUgKi8KPiArI2RlZmluZSBQTVVfR0VO
RVJBTF9OUl9NQVNLICAgICAgKCgoMSA8PCBQTVVfR0VORVJBTF9OUl9CSVRTKSAtIDEpIDw8IFBN
VV9HRU5FUkFMX05SX1NISUZUKQo+ICsKPiArI2RlZmluZSBQTVVfR0VORVJBTF9XSURUSF9TSElG
VCAxNiAgLyogV2lkdGggb2YgZ2VuZXJhbCBwbXUgcmVnaXN0ZXJzICovCj4gKyNkZWZpbmUgUE1V
X0dFTkVSQUxfV0lEVEhfQklUUyAgIDggIC8qIDggYml0cyAxNi4uMjMgKi8KPiArI2RlZmluZSBQ
TVVfR0VORVJBTF9XSURUSF9NQVNLICAoKCgxIDw8IFBNVV9HRU5FUkFMX1dJRFRIX0JJVFMpIC0g
MSkgPDwgUE1VX0dFTkVSQUxfV0lEVEhfU0hJRlQpCj4gKy8qIFJlZ2lzdGVyIGVkeCAqLwo+ICsj
ZGVmaW5lIFBNVV9GSVhFRF9OUl9TSElGVCAgICAgICAwICAvKiBOdW1iZXIgb2YgZml4ZWQgcG11
IHJlZ2lzdGVycyAqLwo+ICsjZGVmaW5lIFBNVV9GSVhFRF9OUl9CSVRTICAgICAgICA1ICAvKiA1
IGJpdHMgMC4uNCAqLwo+ICsjZGVmaW5lIFBNVV9GSVhFRF9OUl9NQVNLICAgICAgICAoKCgxIDw8
IFBNVV9GSVhFRF9OUl9CSVRTKSAtMSkgPDwgUE1VX0ZJWEVEX05SX1NISUZUKQo+ICsKPiArI2Rl
ZmluZSBQTVVfRklYRURfV0lEVEhfU0hJRlQgICAgNSAgLyogV2lkdGggb2YgZml4ZWQgcG11IHJl
Z2lzdGVycyAqLwo+ICsjZGVmaW5lIFBNVV9GSVhFRF9XSURUSF9CSVRTICAgICA4ICAvKiA4IGJp
dHMgNS4uMTIgKi8KPiArI2RlZmluZSBQTVVfRklYRURfV0lEVEhfTUFTSyAgICAgKCgoMSA8PCBQ
TVVfRklYRURfV0lEVEhfQklUUykgLTEpIDw8IFBNVV9GSVhFRF9XSURUSF9TSElGVCkKPiArCj4g
Ky8qCj4gICAqIFFVSVJLIHRvIHdvcmthcm91bmQgYW4gaXNzdWUgb24gTmVoYWxlbSBwcm9jZXNz
b3JzIGN1cnJlbnRseSBzZWVuCj4gICAqIG9uIGZhbWlseSA2IGNwdXMgRTU1MjAgKG1vZGVsIDI2
KSBhbmQgWDc1NDIgKG1vZGVsIDQ2KS4KPiAgICogVGhlIGlzc3VlIGxlYWRzIHRvIGVuZGxlc3Mg
UE1DIGludGVycnVwdCBsb29wcyBvbiB0aGUgcHJvY2Vzc29yLgo+IEBAIC0xMzAsNiArMTU2LDkg
QEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwbXVtc3IgY29yZTJfY3RybHMgPQo+ICB9Owo+ICBzdGF0
aWMgaW50IGFyY2hfcG1jX2NudDsKPiAgCj4gKy8qCj4gKyAqIFJlYWQgdGhlIG51bWJlciBvZiBn
ZW5lcmFsIGNvdW50ZXJzIHZpYSBDUFVJRC5FQVhbMHhhXS5FQVhbOC4uMTVdCj4gKyAqLwo+ICBz
dGF0aWMgaW50IGNvcmUyX2dldF9wbWNfY291bnQodm9pZCkKPiAgewo+ICAgICAgdTMyIGVheCwg
ZWJ4LCBlY3gsIGVkeDsKPiBAQCAtMTM3LDcgKzE2Niw3IEBAIHN0YXRpYyBpbnQgY29yZTJfZ2V0
X3BtY19jb3VudCh2b2lkKQo+ICAgICAgaWYgKCBhcmNoX3BtY19jbnQgPT0gMCApCj4gICAgICB7
Cj4gICAgICAgICAgY3B1aWQoMHhhLCAmZWF4LCAmZWJ4LCAmZWN4LCAmZWR4KTsKPiAtICAgICAg
ICBhcmNoX3BtY19jbnQgPSAoZWF4ICYgMHhmZjAwKSA+PiA4Owo+ICsgICAgICAgIGFyY2hfcG1j
X2NudCA9IChlYXggJiBQTVVfR0VORVJBTF9OUl9NQVNLKSA+PiBQTVVfR0VORVJBTF9OUl9TSElG
VDsKPiAgICAgIH0KPiAgCj4gICAgICByZXR1cm4gYXJjaF9wbWNfY250Owo+IEBAIC0xNTQsOCAr
MTgzLDkgQEAgc3RhdGljIHU2NCBjb3JlMl9jYWxjX2ludGlhbF9nbGJfY3RybF9tcwo+ICBzdGF0
aWMgaW50IGNvcmUyX2dldF9iaXR3aWR0aF9maXhfY291bnQodm9pZCkKPiAgewo+ICAgICAgdTMy
IGVheCwgZWJ4LCBlY3gsIGVkeDsKPiArCj4gICAgICBjcHVpZCgweGEsICZlYXgsICZlYngsICZl
Y3gsICZlZHgpOwo+IC0gICAgcmV0dXJuICgoZWR4ICYgMHgxZmUwKSA+PiA1KTsKPiArICAgIHJl
dHVybiAoKGVkeCAmIFBNVV9GSVhFRF9XSURUSF9NQVNLKSA+PiBQTVVfRklYRURfV0lEVEhfU0hJ
RlQpOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IGlzX2NvcmUyX3ZwbXVfbXNyKHUzMiBtc3JfaW5k
ZXgsIGludCAqdHlwZSwgaW50ICppbmRleCkKPiBAQCAtNzMxLDIzICs3NjEsNiBAQCBzdHJ1Y3Qg
YXJjaF92cG11X29wcyBjb3JlMl92cG11X29wcyA9IHsKPiAgICAgIC5hcmNoX3ZwbXVfbG9hZCA9
IGNvcmUyX3ZwbXVfbG9hZAo+ICB9Owo+ICAKPiAtLyoKPiAtICogU2VlIEludGVsIFNETSBWb2wg
MmEgSW5zdHJ1Y3Rpb24gU2V0IFJlZmVyZW5jIGZvciBDUFVJRCBpbnN0cnVjdGlvbi4KPiAtICog
Y3B1aWQgMHhhIC0gQXJjaGl0ZWN0dXJhbCBQZXJmb3JtYW5jZSBNb25pdG9yaW5nIExlYWYKPiAt
ICogUmVnaXN0ZXIgZWF4Cj4gLSAqLwo+IC0jZGVmaW5lIFg4Nl9GRUFUVVJFX1BNVV9WRVJfT0ZG
ICAgMCAgLyogVmVyc2lvbiBJRCAqLwo+IC0jZGVmaW5lIEZFQVRVUkVfUE1VX1ZFUl9CSVRTICAg
ICAgOCAgLyogOCBiaXRzIDAuLjcgKi8KPiAtI2RlZmluZSBYODZfRkVBVFVSRV9OVU1fR0VOX09G
RiAgIDggIC8qIE51bWJlciBvZiBnZW5lcmFsIHBtdSByZWdpc3RlcnMgKi8KPiAtI2RlZmluZSBG
RUFUVVJFX05VTV9HRU5fQklUUyAgICAgIDggIC8qIDggYml0cyA4Li4xNSAqLwo+IC0jZGVmaW5l
IFg4Nl9GRUFUVVJFX0dFTl9XSURUSF9PRkYgMTYgLyogV2lkdGggb2YgZ2VuZXJhbCBwbXUgcmVn
aXN0ZXJzICovCj4gLSNkZWZpbmUgRkVBVFVSRV9HRU5fV0lEVEhfQklUUyAgICA4ICAvKiA4IGJp
dHMgMTYuLjIzICovCj4gLS8qIFJlZ2lzdGVyIGVkeCAqLwo+IC0jZGVmaW5lIFg4Nl9GRUFUVVJF
X05VTV9GSVhfT0ZGICAgMCAgLyogTnVtYmVyIG9mIGZpeGVkIHBtdSByZWdpc3RlcnMgKi8KPiAt
I2RlZmluZSBGRUFUVVJFX05VTV9GSVhfQklUUyAgICAgIDUgIC8qIDUgYml0cyAwLi40ICovCj4g
LSNkZWZpbmUgWDg2X0ZFQVRVUkVfRklYX1dJRFRIX09GRiA1ICAvKiBXaWR0aCBvZiBmaXhlZCBw
bXUgcmVnaXN0ZXJzICovCj4gLSNkZWZpbmUgRkVBVFVSRV9GSVhfV0lEVEhfQklUUyAgICA4ICAv
KiA4IGJpdHMgNS4uMTIgKi8KPiAtCj4gIHN0YXRpYyB2b2lkIGNvcmUyX25vX3ZwbXVfZG9fY3B1
aWQodW5zaWduZWQgaW50IGlucHV0LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHVuc2lnbmVkIGludCAqZWF4LCB1bnNpZ25lZCBpbnQgKmVieCwKPiAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgKmVjeCwgdW5zaWduZWQgaW50ICplZHgpCj4g
QEAgLTc1OCwxMiArNzcxLDEyIEBAIHN0YXRpYyB2b2lkIGNvcmUyX25vX3ZwbXVfZG9fY3B1aWQo
dW5zaWcKPiAgICAgICAqLwo+ICAgICAgaWYgKCBpbnB1dCA9PSAweGEgKQo+ICAgICAgewo+IC0g
ICAgICAgICplYXggJj0gfigoKDEgPDwgRkVBVFVSRV9QTVVfVkVSX0JJVFMpIC0xKSA8PCBYODZf
RkVBVFVSRV9QTVVfVkVSX09GRik7Cj4gLSAgICAgICAgKmVheCAmPSB+KCgoMSA8PCBGRUFUVVJF
X05VTV9HRU5fQklUUykgLTEpIDw8IFg4Nl9GRUFUVVJFX05VTV9HRU5fT0ZGKTsKPiAtICAgICAg
ICAqZWF4ICY9IH4oKCgxIDw8IEZFQVRVUkVfR0VOX1dJRFRIX0JJVFMpIC0xKSA8PCBYODZfRkVB
VFVSRV9HRU5fV0lEVEhfT0ZGKTsKPiArICAgICAgICAqZWF4ICY9IH5QTVVfVkVSU0lPTl9NQVNL
Owo+ICsgICAgICAgICplYXggJj0gflBNVV9HRU5FUkFMX05SX01BU0s7Cj4gKyAgICAgICAgKmVh
eCAmPSB+UE1VX0dFTkVSQUxfV0lEVEhfTUFTSzsKPiAgCj4gLSAgICAgICAgKmVkeCAmPSB+KCgo
MSA8PCBGRUFUVVJFX05VTV9GSVhfQklUUykgLTEpIDw8IFg4Nl9GRUFUVVJFX05VTV9GSVhfT0ZG
KTsKPiAtICAgICAgICAqZWR4ICY9IH4oKCgxIDw8IEZFQVRVUkVfRklYX1dJRFRIX0JJVFMpIC0x
KSA8PCBYODZfRkVBVFVSRV9GSVhfV0lEVEhfT0ZGKTsKPiArICAgICAgICAqZWR4ICY9IH5QTVVf
RklYRURfTlJfTUFTSzsKPiArICAgICAgICAqZWR4ICY9IH5QTVVfRklYRURfV0lEVEhfTUFTSzsK
PiAgICAgIH0KPiAgfQo+ICAKPiAKPiAKLS0gCkNvbXBhbnkgZGV0YWlsczogaHR0cDovL3RzLmZ1
aml0c3UuY29tL2ltcHJpbnQuaHRtbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVu
Lm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK