From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 1 Jan 2008 21:27:39 +0800 From: WANG Cong Subject: (Try #2) [Patch 3/8] S390: Tiny fixes for Makefile Message-ID: <20080101132739.GC2499@hacking> Reply-To: WANG Cong References: <20080101071311.GA2496@hacking> <20080101072555.GD2496@hacking> <20080101101720.GC28913@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080101101720.GC28913@uranus.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Sam Ravnborg Cc: WANG Cong , Martin Schwidefsky , LKML , linux-kbuild@vger.kernel.org, Andrew Morton , linux-s390@vger.kernel.org List-ID: >> -binfmt_elf32.o: $(TOPDIR)/fs/binfmt_elf.c >> +binfmt_elf32.o: $(objtree)/fs/binfmt_elf.c > >This prerequisite listing looks just bogus and should be removed altogether. >We only need to list prerequisites explicit for generated files. Not so sure whether this is what s390 people do on purpose. Thanks anyway! The following one contains the new fix. ------------> This patch removes TOPDIR and fixes a bogus prerequisite in arch/s390/kernel/Makefile. Cc: Martin Schwidefsky Cc: Sam Ravnborg Signed-off-by: WANG Cong ---- diff --git a/arch/s390/kernel/Makefile b/arch/s390/kernel/Makefile index 56cb710..4accf27 100644 --- a/arch/s390/kernel/Makefile +++ b/arch/s390/kernel/Makefile @@ -20,7 +20,7 @@ obj-$(CONFIG_AUDIT) += audit.o compat-obj-$(CONFIG_AUDIT) += compat_audit.o obj-$(CONFIG_COMPAT) += compat_linux.o compat_signal.o \ compat_wrapper.o compat_exec_domain.o \ - binfmt_elf32.o $(compat-obj-y) + binfmt_elf.o $(compat-obj-y) obj-$(CONFIG_VIRT_TIMER) += vtime.o obj-$(CONFIG_STACKTRACE) += stacktrace.o @@ -34,4 +34,4 @@ obj-$(CONFIG_KEXEC) += $(S390_KEXEC_OBJS) # # This is just to get the dependencies... # -binfmt_elf32.o: $(TOPDIR)/fs/binfmt_elf.c +binfmt_elf.o: $(objtree)/fs/binfmt_elf.c