From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J9hOR-00008c-MD for mharc-grub-devel@gnu.org; Tue, 01 Jan 2008 08:42:55 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J9hOP-00008V-Sw for grub-devel@gnu.org; Tue, 01 Jan 2008 08:42:53 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J9hON-00008J-Hk for grub-devel@gnu.org; Tue, 01 Jan 2008 08:42:52 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J9hON-00008G-CM for grub-devel@gnu.org; Tue, 01 Jan 2008 08:42:51 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J9hOM-00068Z-VF for grub-devel@gnu.org; Tue, 01 Jan 2008 08:42:51 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1J9hOK-0002aP-J0 for grub-devel@gnu.org; Tue, 01 Jan 2008 14:42:50 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1J9hM2-0008Oa-Px for grub-devel@gnu.org; Tue, 01 Jan 2008 14:40:26 +0100 Date: Tue, 1 Jan 2008 14:40:26 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080101134026.GA32057@thorin> References: <20080101124728.GA30417@thorin> <477A3CCA.4090908@nic.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <477A3CCA.4090908@nic.fi> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 13:42:54 -0000 On Tue, Jan 01, 2008 at 03:14:50PM +0200, Vesa Jääskeläinen wrote: > > First some questions ;) > > - What happens when you forgot to provide / in this string ;) ? grub_strchr() returns NULL and... whoops! I'll fix that :-) > - What happens when all memory is used? What do you mean? > - What happens when you alter list of colors... remove one entry of it > or add one. This should never happen. The list is just a human description of GRUB color codes. GRUB VGA-style color codes are never changed in runtime, so neither should this list. > (eg. hard coding is bad... sizeof...) Where can sizeof be used? > Now to your naming issue... > > This code is quite specific to be only local so I would propose following: > > parse_single_color_name -> parse_color_name > > parse_color_name -> parse_color_tuple, parse_color_pair, > parse_text_color or parse_menu_color How about `parse_color_name_pair' ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)