Re: Warning emited by 2.6.24-rc6-git5

[Chris Clayton <chris2553@googlemail.com>]

On Monday 31 December 2007, Ivo Van Doorn wrote:
> On Dec 31, 2007 8:27 AM, Kalle Valo <kalle.valo@nokia.com> wrote:
> > Ivo van Doorn <ivdoorn@gmail.com> writes:
> > > +             /*
> > > +              * Move entire frame 2 bytes to the front.
> > > +              */
> > > +             skb_push(skb, 2);
> > > +             memmove(skb->data, skb->data + 2, skb->len - 2);
> >
> > No skb_trim()? Shoudn't there be skb_trim(skb, 2) after memmove()?
>
> Good point, I completely forgot about that. :S
> Thanks. :)
>
> Ivo

Ah, does the patch I have applied and am running need enhancement, please?

Thanks

-- 
Beer is proof that God loves us and wants us to be happy - Benjamin Franklin