Re: [PATCH] [CFT] Code clarification patch to Kprobes arch code

[Ananth N Mavinakayanahalli <ananth@in.ibm.com>]

On Wed, Jan 02, 2008 at 01:33:55PM +0100, Ingo Molnar wrote:
> 
> * Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> 
> > > Signed-off-by: Quentin Barnes <qbarnes@gmail.com>
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > 
> > Tested on x86.
> > 
> > Acked-by: Ananth N Mavinakayahanalli <ananth@in.ibm.com>
> 
> thanks Ananth, i've updated the patch.

Hi Ingo,

> btw., do you have some script that i could use to test kprobes 
> functionality? Right now the only time i notice kprobes regressions is 
> when randconfig picks up CONFIG_NET_TCPPROBE=y which activates kprobes.
> 
> It would be so much nicer if kprobes had some runs-during-bootup kind of 
> quick self-test, with all the important functionality unit-tested. Like 
> lib/locking-selftest.c, or CONFIG_RCU_TORTURE_TEST=y.

The simplest way to do a basic sanity check is build the kprobes samples/
and try them out. We have one sample each to test kprobes, kretprobes
and jprobes. This should serve the purpose.

I had posted patches for the same sometime back
(http://marc.info/?l=linux-kernel&m=119297044801420&w=2), but they needed
some rework to fix a build break on sparc64
(http://marc.info/?l=linux-kernel&m=119735423212298&w=2).

I will rebase the patchset against the latest mm and repost soon...

Ananth