All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] linux/{socket,stat}.h: change __GLIBC__ cruft to __KLIBC__
Date: Wed, 2 Jan 2008 17:13:35 +0200	[thread overview]
Message-ID: <20080102151335.GA15898@does.not.exist> (raw)
In-Reply-To: <200801020937.50770.vapier@gentoo.org>

On Wed, Jan 02, 2008 at 09:37:50AM -0500, Mike Frysinger wrote:
> The __GLIBC__ hacks were re-added to the headers because the klibc peeps want
> to be lazy.  But rather than properly address things, they just wrongly left
> it as __GLIBC__.  This patch changes the __GLIBC__ cruft to __KLIBC__ so real
> libcs don't get screwed due to kilbc's laziness.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> diff --git a/include/linux/socket.h b/include/linux/socket.h
> index c22ef1c..90af15b 100644
> --- a/include/linux/socket.h
> +++ b/include/linux/socket.h
> @@ -16,7 +16,7 @@ struct __kernel_sockaddr_storage {
>  				/* _SS_MAXSIZE value minus size of ss_family */
>  } __attribute__ ((aligned(_K_SS_ALIGNSIZE)));	/* force desired alignment */
>  
> -#if defined(__KERNEL__) || !defined(__GLIBC__) || (__GLIBC__ < 2)
> +#if defined(__KERNEL__) || defined(__KLIBC__)
>...

This changes the semantics from "!glibc" to "klibc".

I'm a bit worried that such changes might break some of the other 
libc's people use on Linux.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2008-01-02 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 14:37 [patch] linux/{socket,stat}.h: change __GLIBC__ cruft to __KLIBC__ Mike Frysinger
2008-01-02 15:13 ` Adrian Bunk [this message]
2008-01-02 15:47   ` Mike Frysinger
2008-01-02 18:16     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080102151335.GA15898@does.not.exist \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.