From: Olof Johansson <olof@lixom.net>
To: Li Li <r64360@freescale.com>
Cc: Wood Scott <scottwood@freescale.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
kim phillips <Kim.Phillips@freescale.com>
Subject: Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support
Date: Wed, 2 Jan 2008 09:51:10 -0600 [thread overview]
Message-ID: <20080102155110.GA15405@lixom.net> (raw)
In-Reply-To: <1199272605.22416.8.camel@Guyver>
On Wed, Jan 02, 2008 at 07:16:45PM +0800, Li Li wrote:
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1ee009e..f84caa7 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2111,6 +2111,10 @@
> #define PCI_DEVICE_ID_TDI_EHCI 0x0101
>
> #define PCI_VENDOR_ID_FREESCALE 0x1957
> +#define PCI_DEVICE_ID_MPC8378E 0x00c4
> +#define PCI_DEVICE_ID_MPC8378 0x00c5
> +#define PCI_DEVICE_ID_MPC8377E 0x00c6
> +#define PCI_DEVICE_ID_MPC8377 0x00c7
> #define PCI_DEVICE_ID_MPC8548E 0x0012
> #define PCI_DEVICE_ID_MPC8548 0x0013
> #define PCI_DEVICE_ID_MPC8543E 0x0014
In general it's not needed to add device ID's to the global table,
especially when they're only used once or twice. Just use the hex constant
in the driver instead.
-Olof
prev parent reply other threads:[~2008-01-02 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 11:16 [PATCH] powerpc: Add MPC837x PCIE controller RC mode support Li Li
2008-01-02 11:53 ` Arnd Bergmann
2008-01-03 6:40 ` Li Li
2008-01-03 8:14 ` Arnd Bergmann
2008-01-03 8:31 ` Li Li
2008-01-03 10:14 ` Arnd Bergmann
2008-01-03 10:08 ` Li Li
2008-01-02 15:23 ` Kumar Gala
2008-01-03 5:56 ` Li Li
2008-01-02 15:51 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102155110.GA15405@lixom.net \
--to=olof@lixom.net \
--cc=Kim.Phillips@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=r64360@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.