From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
Stefano Brivio <stefano.brivio@polimi.it>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: better rate control algorithm selection
Date: Wed, 2 Jan 2008 16:23:35 +0100 [thread overview]
Message-ID: <200801021623.36089.mb@bu3sch.de> (raw)
In-Reply-To: <1199263934.4172.69.camel@johannes.berg>
On Wednesday 02 January 2008 09:52:14 Johannes Berg wrote:
>
> > Building an algorithm optionally into mac80211 seems rather odd. In
> > case mac80211 the algorithms should be their own modules and you should
> > use request_module to make sure at least one is loaded.
>
> We actually do that but people still manage to mess it up because they
> don't install the modules properly or whatever.
>
> > Or if you
> > really want to make sure one is alway avaiabable always build the
> > simplest one directly and unconditionally into mac80211.ko.
>
> That'd be an alternative too, I think we have something like that now. I
> don't really like it that much though because for 99% of people it's
> just dead code. Anyway, I'll look into Sam's mail and do a new patch
> depending on that.
What about simply _not_ failing the initialization of mac80211, if no
rc algo is available? I mean, we can just use a fixed rate we get through
WEXT and stuff. Simply start at 1M on init in that case and stay at a fixed
1M until the user sets a different fixed rate through WEXT.
--
Greetings Michael.
next prev parent reply other threads:[~2008-01-02 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 16:09 [PATCH] mac80211: better rate control algorithm selection Johannes Berg
2007-12-21 20:00 ` Stefano Brivio
2007-12-21 20:43 ` Johannes Berg
2007-12-21 20:57 ` Stefano Brivio
2007-12-21 21:15 ` Johannes Berg
2007-12-21 21:43 ` [PATCH v2] " Johannes Berg
2007-12-21 22:26 ` Stefano Brivio
2007-12-30 23:11 ` [PATCH] " Sam Ravnborg
2007-12-31 7:45 ` Christoph Hellwig
2008-01-02 8:41 ` Johannes Berg
2008-01-02 8:45 ` Christoph Hellwig
2008-01-02 8:52 ` Johannes Berg
2008-01-02 15:23 ` Michael Buesch [this message]
2008-01-02 15:27 ` Johannes Berg
2008-01-02 15:29 ` Michael Buesch
2008-01-02 23:05 ` Stefano Brivio
2008-01-02 14:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801021623.36089.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=flamingice@sourmilk.net \
--cc=hch@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.