From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Re: [PATCH 06/30] ocfs2: Include do_sync_mapping_range() from mainline
Date: Wed Jan 2 15:10:54 2008 [thread overview]
Message-ID: <20080102231003.GC8779@mail.oracle.com> (raw)
In-Reply-To: <1199139862-31452-5-git-send-email-sunil.mushran@oracle.com>
On Mon, Dec 31, 2007 at 02:23:58PM -0800, Sunil Mushran wrote:
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 4791433..fc7ee22 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -23,11 +23,13 @@
> * Boston, MA 021110-1307, USA.
> */
>
> +#ifndef NO_SYNC_MAPPING_RANGE
> #include <linux/fs.h>
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/highmem.h>
> #include <linux/swap.h>
> +#endif
Why are you adding these #ifdefs? The headers can be included
twice safely, they prevent re-inclusion - or at least they should.
Joel
--
Life's Little Instruction Book #356
"Be there when people need you."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-01-02 15:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 14:25 [Ocfs2-devel] ocfs2-1.4: A new beginning - 2nd attempt Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 21/30] ocfs2: Handle splice.h Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 22/30] ocfs2: Handle missing macro MNT_RELATIME Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 20/30] ocfs2: Handle missing iop->fallocate() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 30/30] ocfs2: Handle missing exportfs.h Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 03/30] ocfs2: Handle workqueue changes Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 07/30] ocfs2: Handle missing vmops->fault() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 23/30] ocfs2: Handles missing export should_remove_suid() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 13/30] ocfs2: Define FS_RENAME_DOES_D_MOVE Sunil Mushran
2008-01-02 15:14 ` [Ocfs2-devel] " Joel Becker
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 28/30] ocfs2: Handle missing __splice_from_pipe() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 26/30] ocfs2: Handle missing const struct inode_operations in struct inode Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 04/30] ocfs2: Handle macro uninitialized_var Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 17/30] ocfs2: Handle su_mutex in struct configfs_subsystem Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 27/30] ocfs2: Handle missing vectorized fileops aio_read() and aio_write() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 12/30] ocfs2: Handle missing dtors in kmem_cache_create() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 09/30] ocfs2: Define enum umh_wait Sunil Mushran
2008-01-02 15:12 ` [Ocfs2-devel] " Joel Becker
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 29/30] ocfs2: Handle older prototype of bi_end_io_t Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 10/30] ocfs2: Add helper inc_nlink Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 05/30] ocfs2: Handle macro zero_user_page() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 16/30] ocfs2: Handle different prototypes of register_sysctl_table() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 08/30] ocfs2: Handle struct f_path in struct file Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 06/30] ocfs2: Include do_sync_mapping_range() from mainline Sunil Mushran
2008-01-02 15:10 ` Joel Becker [this message]
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 14/30] ocfs2: Handle enum value FS_OCFS2 Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 18/30] ocfs2: Handle the removal of struct subsystem Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 15/30] ocfs2: Handles configfs_depend_item() and configfs_undepend_item() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 11/30] ocfs2: Add helper drop_nlink Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 24/30] ocfs2: Handle missing export generic_segment_checks() Sunil Mushran
2007-12-31 14:25 ` [Ocfs2-devel] [PATCH 19/30] ocfs2: Handle missing macro is_owner_or_cap() Sunil Mushran
2007-12-31 14:26 ` [Ocfs2-devel] [PATCH 25/30] ocfs2: Handle missing const s_op in struct super_block Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102231003.GC8779@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.