From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JADDs-0000s9-7X for mharc-grub-devel@gnu.org; Wed, 02 Jan 2008 18:42:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JADDp-0000rU-G0 for grub-devel@gnu.org; Wed, 02 Jan 2008 18:42:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JADDo-0000rI-0c for grub-devel@gnu.org; Wed, 02 Jan 2008 18:42:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JADDn-0000rF-RS for grub-devel@gnu.org; Wed, 02 Jan 2008 18:42:03 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JADDn-0007tj-KW for grub-devel@gnu.org; Wed, 02 Jan 2008 18:42:03 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 10B513EB24 for ; Thu, 3 Jan 2008 00:46:44 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 3 Jan 2008 00:42:01 +0100 User-Agent: KMail/1.9.4 References: <20080101124728.GA30417@thorin> In-Reply-To: <20080101124728.GA30417@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801030042.01855.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2008 23:42:05 -0000 On Tuesday 01 January 2008 13:47, Robert Millan wrote: > This patch allows the following to work: > > set color_normal=cyan/blue > set color_highlight=white/blue Although I am not a native speaker, I feel that they should be better called "normal_color" and "highlight_color". > which is equivalent to this command in GRUB Legacy: > > color cyan/blue white/blue > > I haven't written a ChangeLog entry yet, because I'd like to receive > comments on the function names. I don't really like > `parse_single_color_name' and `parse_color_name' but I don't know what to > call them :-(. What conventions are there for referring to single colors > (i.e. those that describe only FG or only BG, not both) and complete colors > (FG + BG) ? No such word, AFAIK. You know, it is ugly, because you want to put two separate things into one place. ;) Just look at CSS... div { color: black; background-color: white; } So, if you don't hesitate to create so many variables, you can simply create "normal_color", "normal_background_color", "highlight_color" and "highlight_background_color", although I don't know who would like it. Okuji