From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAEWN-0004sM-2I for mharc-grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAEWL-0004rJ-Nf for grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAEWK-0004q2-92 for grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:17 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAEWK-0004pz-5r for grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:16 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAEWJ-0002rp-Tz for grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:16 -0500 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JAEWJ-0005eE-BX for grub-devel@gnu.org; Wed, 02 Jan 2008 20:05:15 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAEQ4-0005lQ-FR for grub-devel@gnu.org; Thu, 03 Jan 2008 01:58:48 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAEOF-0001p5-G4 for grub-devel@gnu.org; Thu, 03 Jan 2008 01:56:55 +0100 Date: Thu, 3 Jan 2008 01:56:55 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080103005655.GB6843@thorin> References: <20080101124728.GA30417@thorin> <20080101173806.GA3440@thorin> <20080102214831.GA6322@thorin> <200801030055.48575.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801030055.48575.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 01:05:17 -0000 On Thu, Jan 03, 2008 at 12:55:48AM +0100, Yoshinori K. Okuji wrote: > On Wednesday 02 January 2008 22:48, Robert Millan wrote: > > On Tue, Jan 01, 2008 at 06:38:06PM +0100, Robert Millan wrote: > > > `color' command is necessary to propagate user setting from environment > > > variables to the internal color of our current terminal. > > > > Vesa suggested (on IRC) to use write hooks (grub_env_write_hook_t) in > > variables to avoid this. I tend to agree. What do others think? > > Generally speaking, if you are planning to read settings by scripting, it is > better to use a variable. If you are planning to change the behavior by > options, it is better to use a command. > > Or, semantically, if you want to make an action, a command is suitable. If you > want to set a state, a variable is more appropriate. > > Anyway, you can accomplish nearly the same thing with both, thanks to the > hooks, so the choice is mostly a matter of taste. > > Personally, I think this should come up with variables. It is just like a > prompt in bash for me. Ok, variables then. It's also more consistent, since the `color' command I implemented was reliing on variables anyway. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)