From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAEZD-0005xJ-Az for mharc-grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:15 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAEZA-0005wQ-SK for grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAEZ7-0005uB-TL for grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:11 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAEZ7-0005u0-J2 for grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:09 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAEZ7-0003Ma-CK for grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:09 -0500 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JAEZ6-0005uP-PA for grub-devel@gnu.org; Wed, 02 Jan 2008 20:08:08 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAEXb-0005lq-UR for grub-devel@gnu.org; Thu, 03 Jan 2008 02:06:36 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAEVK-0001sA-K6 for grub-devel@gnu.org; Thu, 03 Jan 2008 02:04:14 +0100 Date: Thu, 3 Jan 2008 02:04:14 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080103010414.GC6843@thorin> References: <20080101124728.GA30417@thorin> <200801030042.01855.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801030042.01855.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 01:08:13 -0000 On Thu, Jan 03, 2008 at 12:42:01AM +0100, Yoshinori K. Okuji wrote: > On Tuesday 01 January 2008 13:47, Robert Millan wrote: > > This patch allows the following to work: > > > > set color_normal=cyan/blue > > set color_highlight=white/blue > > Although I am not a native speaker, I feel that they should be better > called "normal_color" and "highlight_color". I like to come up with names that share their prefix, because this makes the set more readable: set color_normal=cyan/blue set color_highlight=white/blue set normal_color=cyan/blue set highlight_color=white/blue In the first one the "color_" section is easier to identify. Althogh I don't feel strongly about this of course :-) > > which is equivalent to this command in GRUB Legacy: > > > > color cyan/blue white/blue > > > > I haven't written a ChangeLog entry yet, because I'd like to receive > > comments on the function names. I don't really like > > `parse_single_color_name' and `parse_color_name' but I don't know what to > > call them :-(. What conventions are there for referring to single colors > > (i.e. those that describe only FG or only BG, not both) and complete colors > > (FG + BG) ? > > No such word, AFAIK. You know, it is ugly, because you want to put two > separate things into one place. ;) > > Just look at CSS... > > div { > color: black; > background-color: white; > } > > So, if you don't hesitate to create so many variables, you can simply > create "normal_color", "normal_background_color", "highlight_color" > and "highlight_background_color", although I don't know who would like it. Sounds like this could save us some code space. I'd go for _fg and _bg to preserve alignment in the names. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)