From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAEbG-0006Wo-9p for mharc-grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAEbE-0006WY-If for grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAEbD-0006WM-3o for grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAEbD-0006WJ-0p for grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:19 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAEbC-0003if-Eo for grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:18 -0500 Received: from aybabtu.com ([69.60.117.155]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JAEbB-000666-Mh for grub-devel@gnu.org; Wed, 02 Jan 2008 20:10:17 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAEZj-0005lz-Qe for grub-devel@gnu.org; Thu, 03 Jan 2008 02:08:48 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAEXd-0001tq-92 for grub-devel@gnu.org; Thu, 03 Jan 2008 02:06:37 +0100 Date: Thu, 3 Jan 2008 02:06:37 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080103010637.GD6843@thorin> References: <20080102170533.GA29024@thorin> <200801030046.15405.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801030046.15405.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] memtest86+ fix X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 01:10:20 -0000 On Thu, Jan 03, 2008 at 12:46:15AM +0100, Yoshinori K. Okuji wrote: > On Wednesday 02 January 2008 18:05, Robert Millan wrote: > > This fixes boot for memtest86+ (and actually, Linux zImages since they were > > all affected). > > > > The problem was that the first code in grub_linux_boot_zimage copied the > > payload from 0x100000 to 0x10000. Since GRUB starts at 0x8200 and is > > typicaly more than 8 kiB in size, it'll most likely overwrite part of it. > > > > A bit of reestructuring was necessary to allow grub_dl_unload_all() to > > happen unconditionally as first step, since the information on whether this > > is a "big linux" was not promptly available. > > > > Comments? > > It is okay, except for "grub_linux_big"... I cannot figure out what it wants > to say. As you want to make it global, please choose a more expressive name, > such as "grub_big_linux_loaded". How about "grub_linux_big_loaded", for consistency with the other vars in that also start with grub_linux_ ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)