From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Robert Reif <reif@earthlink.net>
Subject: Re: [Qemu-devel] [PATCH] fix possible NULL pointer use in hw/ptimer.c
Date: Thu, 3 Jan 2008 02:43:10 +0000 [thread overview]
Message-ID: <200801030243.13180.paul@codesourcery.com> (raw)
In-Reply-To: <477C489C.1000208@earthlink.net>
> s = (ptimer_state *)qemu_mallocz(sizeof(ptimer_state));
> + if (!s)
> + return NULL;
None of the callers bother to check the return value, And even if they did I
don't think there's any point trying to gracefully handle OOM. Just abort
and be done with it.
I suggest guaranteeing that qemu_malloc will never return NULL, and removing
the null checks from all the various users.
Paul
next prev parent reply other threads:[~2008-01-03 2:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 2:29 [Qemu-devel] [PATCH] fix possible NULL pointer use in hw/ptimer.c Robert Reif
2008-01-03 2:43 ` Paul Brook [this message]
2008-01-03 2:57 ` Robert Reif
2008-01-03 14:02 ` Paul Brook
2008-01-04 17:29 ` Markus Hitter
2008-01-04 17:44 ` Paul Brook
2008-01-04 18:14 ` Robert Reif
2008-01-05 0:44 ` Rob Landley
2008-01-05 1:07 ` Paul Brook
2008-01-05 2:47 ` Rob Landley
2008-01-05 9:55 ` Markus Hitter
2008-01-06 12:14 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801030243.13180.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=reif@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.