From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Thu, 03 Jan 2008 09:21:04 +0000 Subject: Re: [RFC PATCH 01/11] Add basic support for gcc profiler Message-Id: <20080103092104.GE10813@elte.hu> List-Id: References: <20080103071609.478486470@goodmis.org> <20080103072226.776141236@goodmis.org> In-Reply-To: <20080103072226.776141236@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Steven Rostedt Cc: LKML , Linus Torvalds , Andrew Morton , Peter Zijlstra , Christoph Hellwig , Mathieu Desnoyers , Gregory Haskins , Arnaldo Carvalho de Melo , "William L. Irwin" , Steven Rostedt * Steven Rostedt wrote: > +# function tracing might turn this off: > +config REGPARM > + bool > + depends on !MCOUNT > + default y are you sure -pg really needs this? I just carried this along the years and went the path of least resistence, but we should not be reintroducing the !REGPARM build mode for the kernel. I'd not be surprised if there were a few issues with REGPARM + mcount, but we have to figure it out before merging ... Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028AbYACJVp (ORCPT ); Thu, 3 Jan 2008 04:21:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753945AbYACJVh (ORCPT ); Thu, 3 Jan 2008 04:21:37 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:33769 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752440AbYACJVf (ORCPT ); Thu, 3 Jan 2008 04:21:35 -0500 Date: Thu, 3 Jan 2008 10:21:04 +0100 From: Ingo Molnar To: Steven Rostedt Cc: LKML , Linus Torvalds , Andrew Morton , Peter Zijlstra , Christoph Hellwig , Mathieu Desnoyers , Gregory Haskins , Arnaldo Carvalho de Melo , "William L. Irwin" , Steven Rostedt Subject: Re: [RFC PATCH 01/11] Add basic support for gcc profiler instrumentation Message-ID: <20080103092104.GE10813@elte.hu> References: <20080103071609.478486470@goodmis.org> <20080103072226.776141236@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103072226.776141236@goodmis.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > +# function tracing might turn this off: > +config REGPARM > + bool > + depends on !MCOUNT > + default y are you sure -pg really needs this? I just carried this along the years and went the path of least resistence, but we should not be reintroducing the !REGPARM build mode for the kernel. I'd not be surprised if there were a few issues with REGPARM + mcount, but we have to figure it out before merging ... Ingo