From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAOPr-0008TO-GH for mharc-grub-devel@gnu.org; Thu, 03 Jan 2008 06:39:15 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAOPp-0008R7-T2 for grub-devel@gnu.org; Thu, 03 Jan 2008 06:39:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAOPo-0008OO-2Z for grub-devel@gnu.org; Thu, 03 Jan 2008 06:39:13 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAOPn-0008O9-SK for grub-devel@gnu.org; Thu, 03 Jan 2008 06:39:11 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAOPn-0005E0-Ls for grub-devel@gnu.org; Thu, 03 Jan 2008 06:39:11 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAOPG-0006ii-1C for grub-devel@gnu.org; Thu, 03 Jan 2008 12:38:42 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAOMG-0001g4-7U for grub-devel@gnu.org; Thu, 03 Jan 2008 12:35:32 +0100 Date: Thu, 3 Jan 2008 12:35:32 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080103113532.GA6358@thorin> References: <200801030019.24885.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Transparent decompression with file system filter X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 11:39:14 -0000 On Thu, Jan 03, 2008 at 04:49:24PM +0800, Bean wrote: > On Jan 3, 2008 7:19 AM, Yoshinori K. Okuji wrote: > > > > On Monday 31 December 2007 17:59, Bean wrote: > > > Hi, > > > > > > Changes in this new patch: > > > > > > 1, change function name grub_file_open_raw to grub_file_ropen > > > 2, replace grub_file_open in command/blocklist.c and > > > util/i386/pc/grub-setup.c to grub_file_ropen. > > > > > > If nobody objects, i would like to commit this in a few days. > > > > Please wait a minute. Personally, I don't want grub_file_open to decompress a > > content automatically. The name should stand for what it does. That was why I > > named grub_file_open and grub_gzfile_open like this. This was really one of > > what I didn't like in GRUB Legacy. > > > > If you want to have a function to open any kind of compressed file, please add > > something else (e.g. grub_compressed_file_open). > > ok, i keep grub_file_open as it is, and add a new function > grub_zfile_open to handle compressed file. How does grub_zfile_open differ from grub_gzfile_open ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)