From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAReV-0008Cd-I0 for mharc-grub-devel@gnu.org; Thu, 03 Jan 2008 10:06:35 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAReT-0008BO-1Y for grub-devel@gnu.org; Thu, 03 Jan 2008 10:06:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAReR-0008AV-7b for grub-devel@gnu.org; Thu, 03 Jan 2008 10:06:32 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAReR-0008AO-28 for grub-devel@gnu.org; Thu, 03 Jan 2008 10:06:31 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAReQ-0007MM-Qh for grub-devel@gnu.org; Thu, 03 Jan 2008 10:06:30 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JARe0-00070N-D7 for grub-devel@gnu.org; Thu, 03 Jan 2008 16:06:07 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JARbD-0005R6-H4 for grub-devel@gnu.org; Thu, 03 Jan 2008 16:03:11 +0100 Date: Thu, 3 Jan 2008 16:03:11 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080103150311.GA20790@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: variable hooks & global variables X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 15:06:33 -0000 When you set a variable hook (grub_register_variable_hook), this hook isn't preserved after someone (e.g. configfile command) opens a new context (grub_env_context_open), unless the variable has been set as global (grub_env_export). Is this what we want? The only current user of variable hooks is "root" variable, and that hook contains a sanity check that seems to be more suitable for global scope. The color-related variables for which I wanted to add hooks would also like to keep their hooks across contexts. One option is to export these variables, or to modify grub_env_context_open() to preserve hooks as well as exported variables. I'm more inclined for the latter. Comments? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)