From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JARhF-0000vq-80 for mharc-grub-devel@gnu.org; Thu, 03 Jan 2008 10:09:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JARhC-0000us-I4 for grub-devel@gnu.org; Thu, 03 Jan 2008 10:09:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JARhB-0000u8-4R for grub-devel@gnu.org; Thu, 03 Jan 2008 10:09:22 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JARhA-0000u1-OA for grub-devel@gnu.org; Thu, 03 Jan 2008 10:09:20 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JARhA-0007zW-DL for grub-devel@gnu.org; Thu, 03 Jan 2008 10:09:20 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JARgj-00070U-9E for grub-devel@gnu.org; Thu, 03 Jan 2008 16:08:55 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JARdu-0005iN-4o for grub-devel@gnu.org; Thu, 03 Jan 2008 16:05:58 +0100 Date: Thu, 3 Jan 2008 16:05:58 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080103150558.GA21928@thorin> References: <20080103150311.GA20790@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103150311.GA20790@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: variable hooks & global variables X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 15:09:22 -0000 On Thu, Jan 03, 2008 at 04:03:11PM +0100, Robert Millan wrote: > > When you set a variable hook (grub_register_variable_hook), this hook isn't > preserved after someone (e.g. configfile command) opens a new context > (grub_env_context_open), unless the variable has been set as global > (grub_env_export). > > Is this what we want? > > The only current user of variable hooks is "root" variable, and that hook > contains a sanity check that seems to be more suitable for global scope. > > The color-related variables for which I wanted to add hooks would also > like to keep their hooks across contexts. > > One option is to export these variables, or to modify grub_env_context_open() > to preserve hooks as well as exported variables. I'm more inclined for the > latter. > > Comments? Erm, ignore the part about global variables. Exporting them doesn't help: for (var = context->prev->vars[i]; var; var = var->next) { if (var->type == GRUB_ENV_VAR_GLOBAL) if (grub_env_set (var->name, var->value) != GRUB_ERR_NONE) { grub_env_context_close (); return grub_errno; } } So, we just preserve hooks ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)