From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAT9X-0007LP-EH for mharc-grub-devel@gnu.org; Thu, 03 Jan 2008 11:42:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAT9V-0007Jd-IG for grub-devel@gnu.org; Thu, 03 Jan 2008 11:42:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAT9T-0007Gn-Bz for grub-devel@gnu.org; Thu, 03 Jan 2008 11:42:40 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAT9T-0007GX-5O for grub-devel@gnu.org; Thu, 03 Jan 2008 11:42:39 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAT9S-0004F3-TY for grub-devel@gnu.org; Thu, 03 Jan 2008 11:42:39 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAT8t-0007Cf-Pa for grub-devel@gnu.org; Thu, 03 Jan 2008 17:42:07 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAT5t-0007Av-3C for grub-devel@gnu.org; Thu, 03 Jan 2008 17:38:57 +0100 Date: Thu, 3 Jan 2008 17:38:57 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080103163857.GA27449@thorin> References: <20080101124728.GA30417@thorin> <200801030042.01855.okuji@enbug.org> <20080103010414.GC6843@thorin> <20080103153533.GA24992@thorin> <477D07AB.5000904@nic.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <477D07AB.5000904@nic.fi> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2008 16:42:42 -0000 On Thu, Jan 03, 2008 at 06:04:59PM +0200, Vesa Jääskeläinen wrote: > > About error handling: > > Why not call grub_error() with error message and just return from > callback, and let prompt handle error processing (grub_print_error()). > This would keep error reporting centralized. One thing I don't like about grub_error() is that I never know what value to pick for the first parameter. I find this confusing :-/ -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)